test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Rami Rosen <rami.rosen@intel.com>, dts@dpdk.org
Cc: yufengx.mo@intel.com
Subject: Re: [dts] [PATCH] tests: fix initialization in initialize_port_config() of IPGRE test suite.
Date: Thu, 25 Aug 2016 14:18:11 +0800	[thread overview]
Message-ID: <57BE8DA3.8030606@intel.com> (raw)
In-Reply-To: <1471699610-12048-1-git-send-email-rami.rosen@intel.com>

Thanks Rami, applied.

On 08/20/2016 09:26 PM, Rami Rosen wrote:
> This patch removes the initialization of self.outer_mac_src to "11:22:33:44:55:66"
> in initialize_port_config(() as this initialization is wrong and meaningless (self.outer_mac_src
> is being initialized to '00:00:10:00:00:00' immediately in the command after).
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   tests/TestSuite_ipgre.py | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
> index a403ded..0868ffc 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -77,7 +77,6 @@ class TestIpgre(TestCase):
>           self.re_bind_nvgre_to_gre()
>   
>       def initialize_port_config(self):
> -        self.outer_mac_src = "11:22:33:44:55:66"
>           self.outer_mac_src = '00:00:10:00:00:00'
>           self.outer_mac_dst = '11:22:33:44:55:66'
>           self.outer_ip_src = '192.168.1.1'

      reply	other threads:[~2016-08-25  6:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20 13:26 Rami Rosen
2016-08-25  6:18 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE8DA3.8030606@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=rami.rosen@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).