* [dts] [PATCH] tests: fix initialization in initialize_port_config() of IPGRE test suite.
@ 2016-08-20 13:26 Rami Rosen
2016-08-25 6:18 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2016-08-20 13:26 UTC (permalink / raw)
To: dts; +Cc: yufengx.mo, Rami Rosen
This patch removes the initialization of self.outer_mac_src to "11:22:33:44:55:66"
in initialize_port_config(() as this initialization is wrong and meaningless (self.outer_mac_src
is being initialized to '00:00:10:00:00:00' immediately in the command after).
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
tests/TestSuite_ipgre.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index a403ded..0868ffc 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -77,7 +77,6 @@ class TestIpgre(TestCase):
self.re_bind_nvgre_to_gre()
def initialize_port_config(self):
- self.outer_mac_src = "11:22:33:44:55:66"
self.outer_mac_src = '00:00:10:00:00:00'
self.outer_mac_dst = '11:22:33:44:55:66'
self.outer_ip_src = '192.168.1.1'
--
2.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] tests: fix initialization in initialize_port_config() of IPGRE test suite.
2016-08-20 13:26 [dts] [PATCH] tests: fix initialization in initialize_port_config() of IPGRE test suite Rami Rosen
@ 2016-08-25 6:18 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-08-25 6:18 UTC (permalink / raw)
To: Rami Rosen, dts; +Cc: yufengx.mo
Thanks Rami, applied.
On 08/20/2016 09:26 PM, Rami Rosen wrote:
> This patch removes the initialization of self.outer_mac_src to "11:22:33:44:55:66"
> in initialize_port_config(() as this initialization is wrong and meaningless (self.outer_mac_src
> is being initialized to '00:00:10:00:00:00' immediately in the command after).
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
> tests/TestSuite_ipgre.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
> index a403ded..0868ffc 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -77,7 +77,6 @@ class TestIpgre(TestCase):
> self.re_bind_nvgre_to_gre()
>
> def initialize_port_config(self):
> - self.outer_mac_src = "11:22:33:44:55:66"
> self.outer_mac_src = '00:00:10:00:00:00'
> self.outer_mac_dst = '11:22:33:44:55:66'
> self.outer_ip_src = '192.168.1.1'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-25 6:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-20 13:26 [dts] [PATCH] tests: fix initialization in initialize_port_config() of IPGRE test suite Rami Rosen
2016-08-25 6:18 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).