From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 6DE1C58D4
 for <dts@dpdk.org>; Thu, 25 Aug 2016 08:14:38 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga104.jf.intel.com with ESMTP; 24 Aug 2016 23:14:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,574,1464678000"; d="scan'208";a="1046911438"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga002.fm.intel.com with ESMTP; 24 Aug 2016 23:14:37 -0700
Message-ID: <57BE8DA3.8030606@intel.com>
Date: Thu, 25 Aug 2016 14:18:11 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rami Rosen <rami.rosen@intel.com>, dts@dpdk.org
CC: yufengx.mo@intel.com
References: <1471699610-12048-1-git-send-email-rami.rosen@intel.com>
In-Reply-To: <1471699610-12048-1-git-send-email-rami.rosen@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] tests: fix initialization in
 initialize_port_config() of IPGRE test suite.
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Aug 2016 06:14:38 -0000

Thanks Rami, applied.

On 08/20/2016 09:26 PM, Rami Rosen wrote:
> This patch removes the initialization of self.outer_mac_src to "11:22:33:44:55:66"
> in initialize_port_config(() as this initialization is wrong and meaningless (self.outer_mac_src
> is being initialized to '00:00:10:00:00:00' immediately in the command after).
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   tests/TestSuite_ipgre.py | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
> index a403ded..0868ffc 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -77,7 +77,6 @@ class TestIpgre(TestCase):
>           self.re_bind_nvgre_to_gre()
>   
>       def initialize_port_config(self):
> -        self.outer_mac_src = "11:22:33:44:55:66"
>           self.outer_mac_src = '00:00:10:00:00:00'
>           self.outer_mac_dst = '11:22:33:44:55:66'
>           self.outer_ip_src = '192.168.1.1'