test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Rami Rosen <rami.rosen@intel.com>, dts@dpdk.org
Cc: yufengx.mo@intel.com
Subject: Re: [dts] [PATCH] test_plans: fix wrong filter type parameter in GRE test plan.
Date: Thu, 25 Aug 2016 14:19:40 +0800	[thread overview]
Message-ID: <57BE8DFC.9060509@intel.com> (raw)
In-Reply-To: <1471700265-12701-1-git-send-email-rami.rosen@intel.com>

Thanks, applied.

On 08/20/2016 09:37 PM, Rami Rosen wrote:
> The call to "tunnel_filter rm" should get oip and not iip as the
> filter type parameter, as the rule that was added immediately before
> has oip as the filter type parameter and not iip.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   test_plans/ipgre_test_plan.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test_plans/ipgre_test_plan.rst b/test_plans/ipgre_test_plan.rst
> index 444efdf..0dc131b 100644
> --- a/test_plans/ipgre_test_plan.rst
> +++ b/test_plans/ipgre_test_plan.rst
> @@ -144,7 +144,7 @@ Send packet outer ip address matched and check packet recevied by queue 3.
>    
>   Remove tunnel filter and check same packet recevied by queue 0.
>   	testpmd> tunnel_filter rm 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
> -	         0.0.0.0 1 ipingre iip 0 3
> +	         0.0.0.0 1 ipingre oip 0 3
>   
>   Test Case 4: GRE packet chksum offload
>   ====================================

      reply	other threads:[~2016-08-25  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20 13:37 Rami Rosen
2016-08-25  6:19 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE8DFC.9060509@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=rami.rosen@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).