From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 214D5591F
 for <dts@dpdk.org>; Thu, 25 Aug 2016 08:16:07 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 24 Aug 2016 23:16:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,574,1464678000"; d="scan'208";a="1046912174"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga002.fm.intel.com with ESMTP; 24 Aug 2016 23:16:05 -0700
Message-ID: <57BE8DFC.9060509@intel.com>
Date: Thu, 25 Aug 2016 14:19:40 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rami Rosen <rami.rosen@intel.com>, dts@dpdk.org
CC: yufengx.mo@intel.com
References: <1471700265-12701-1-git-send-email-rami.rosen@intel.com>
In-Reply-To: <1471700265-12701-1-git-send-email-rami.rosen@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] test_plans: fix wrong filter type parameter in
 GRE test plan.
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Aug 2016 06:16:09 -0000

Thanks, applied.

On 08/20/2016 09:37 PM, Rami Rosen wrote:
> The call to "tunnel_filter rm" should get oip and not iip as the
> filter type parameter, as the rule that was added immediately before
> has oip as the filter type parameter and not iip.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   test_plans/ipgre_test_plan.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test_plans/ipgre_test_plan.rst b/test_plans/ipgre_test_plan.rst
> index 444efdf..0dc131b 100644
> --- a/test_plans/ipgre_test_plan.rst
> +++ b/test_plans/ipgre_test_plan.rst
> @@ -144,7 +144,7 @@ Send packet outer ip address matched and check packet recevied by queue 3.
>    
>   Remove tunnel filter and check same packet recevied by queue 0.
>   	testpmd> tunnel_filter rm 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
> -	         0.0.0.0 1 ipingre iip 0 3
> +	         0.0.0.0 1 ipingre oip 0 3
>   
>   Test Case 4: GRE packet chksum offload
>   ====================================