test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] modify DTS stop_ports error on freesbd
Date: Mon, 05 Sep 2016 10:16:55 +0800	[thread overview]
Message-ID: <57CCD597.2010108@intel.com> (raw)
In-Reply-To: <1472717373-15005-1-git-send-email-gangx.xu@intel.com>

Gang, both freebsd and linux pci address format should be same. Please 
modify scan_ports_uncached_freebsd generate format.

On 09/01/2016 04:09 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/dut.py | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/framework/dut.py b/framework/dut.py
> index 2f4e53a..14958c9 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -237,10 +237,16 @@ class Dut(Crb):
>               if driver is not None:
>                   # unbind device driver
>                   addr_array = pci_bus.split(':')
> -                domain_id = addr_array[0]
> -                bus_id = addr_array[1]
> -                devfun_id = addr_array[2]
> -                port = GetNicObj(self, domain_id, bus_id, devfun_id)
> +                if len(addr_array) == 3:
> +                    domain_id = addr_array[0]
> +                    bus_id = addr_array[1]
> +                    devfun_id = addr_array[2]
> +                    port = GetNicObj(self, domain_id, bus_id, devfun_id)
> +                elif len(addr_array) == 2:
> +                    domain_id = addr_array[0]
> +                    bus_id = addr_array[1]
> +                    port = GetNicObj(self, domain_id, bus_id, '')
> +
>                   port.stop()
>   
>       def restore_interfaces_linux(self):

      parent reply	other threads:[~2016-09-05  2:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  8:09 xu,gang
2016-09-02  0:24 ` [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD Xu, HuilongX
2016-09-05  2:16 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57CCD597.2010108@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).