* [dts] [PATCH V1] modify DTS stop_ports error on freesbd
@ 2016-09-01 8:09 xu,gang
2016-09-02 0:24 ` [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD Xu, HuilongX
2016-09-05 2:16 ` [dts] [PATCH V1] modify DTS stop_ports error on freesbd Liu, Yong
0 siblings, 2 replies; 3+ messages in thread
From: xu,gang @ 2016-09-01 8:09 UTC (permalink / raw)
To: dts; +Cc: xu,gang
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
framework/dut.py | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/framework/dut.py b/framework/dut.py
index 2f4e53a..14958c9 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -237,10 +237,16 @@ class Dut(Crb):
if driver is not None:
# unbind device driver
addr_array = pci_bus.split(':')
- domain_id = addr_array[0]
- bus_id = addr_array[1]
- devfun_id = addr_array[2]
- port = GetNicObj(self, domain_id, bus_id, devfun_id)
+ if len(addr_array) == 3:
+ domain_id = addr_array[0]
+ bus_id = addr_array[1]
+ devfun_id = addr_array[2]
+ port = GetNicObj(self, domain_id, bus_id, devfun_id)
+ elif len(addr_array) == 2:
+ domain_id = addr_array[0]
+ bus_id = addr_array[1]
+ port = GetNicObj(self, domain_id, bus_id, '')
+
port.stop()
def restore_interfaces_linux(self):
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD
2016-09-01 8:09 [dts] [PATCH V1] modify DTS stop_ports error on freesbd xu,gang
@ 2016-09-02 0:24 ` Xu, HuilongX
2016-09-05 2:16 ` [dts] [PATCH V1] modify DTS stop_ports error on freesbd Liu, Yong
1 sibling, 0 replies; 3+ messages in thread
From: Xu, HuilongX @ 2016-09-02 0:24 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Hi gang,
Pls see my comments as below.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Thursday, September 01, 2016 4:10 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] modify DTS stop_ports error on freesbd
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> framework/dut.py | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/framework/dut.py b/framework/dut.py
> index 2f4e53a..14958c9 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -237,10 +237,16 @@ class Dut(Crb):
> if driver is not None:
> # unbind device driver
> addr_array = pci_bus.split(':')
> - domain_id = addr_array[0]
> - bus_id = addr_array[1]
> - devfun_id = addr_array[2]
> - port = GetNicObj(self, domain_id, bus_id, devfun_id)
1. Domain_id and bus_id is public code.
You should set vale in out of if...elif.
2. devfun_id shoud set vale is addr_array[2] or ''
> + if len(addr_array) == 3:
> + domain_id = addr_array[0]
> + bus_id = addr_array[1]
> + devfun_id = addr_array[2]
> + port = GetNicObj(self, domain_id, bus_id, devfun_id)
> + elif len(addr_array) == 2:
> + domain_id = addr_array[0]
> + bus_id = addr_array[1]
> + port = GetNicObj(self, domain_id, bus_id, '')
> +
> port.stop()
>
> def restore_interfaces_linux(self):
> --
> 1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] modify DTS stop_ports error on freesbd
2016-09-01 8:09 [dts] [PATCH V1] modify DTS stop_ports error on freesbd xu,gang
2016-09-02 0:24 ` [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD Xu, HuilongX
@ 2016-09-05 2:16 ` Liu, Yong
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2016-09-05 2:16 UTC (permalink / raw)
To: xu,gang, dts
Gang, both freebsd and linux pci address format should be same. Please
modify scan_ports_uncached_freebsd generate format.
On 09/01/2016 04:09 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> framework/dut.py | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/framework/dut.py b/framework/dut.py
> index 2f4e53a..14958c9 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -237,10 +237,16 @@ class Dut(Crb):
> if driver is not None:
> # unbind device driver
> addr_array = pci_bus.split(':')
> - domain_id = addr_array[0]
> - bus_id = addr_array[1]
> - devfun_id = addr_array[2]
> - port = GetNicObj(self, domain_id, bus_id, devfun_id)
> + if len(addr_array) == 3:
> + domain_id = addr_array[0]
> + bus_id = addr_array[1]
> + devfun_id = addr_array[2]
> + port = GetNicObj(self, domain_id, bus_id, devfun_id)
> + elif len(addr_array) == 2:
> + domain_id = addr_array[0]
> + bus_id = addr_array[1]
> + port = GetNicObj(self, domain_id, bus_id, '')
> +
> port.stop()
>
> def restore_interfaces_linux(self):
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-05 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 8:09 [dts] [PATCH V1] modify DTS stop_ports error on freesbd xu,gang
2016-09-02 0:24 ` [dts] [PATCH V1] modify DTS stop_ports error on FreeBSD Xu, HuilongX
2016-09-05 2:16 ` [dts] [PATCH V1] modify DTS stop_ports error on freesbd Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).