test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] fix vxlan failed case
Date: Thu, 08 Sep 2016 16:04:52 +0800	[thread overview]
Message-ID: <57D11BA4.8030505@intel.com> (raw)
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A4637B93D8E@SHSMSX101.ccr.corp.intel.com>

OK, merged in this temporary solution.

On 08/25/2016 03:09 PM, Xu, HuilongX wrote:
> Hi yong,
> I think, dts framework should compile many times for different compile switch.
> Then case should  choose different dpdk APP for test.
> Could you merge this patch fist, and we can submit a new patch for dts framework compile many dpdk with different compile switch.
> Thanks a lot
>
>> -----Original Message-----
>> From: Liu, Yong
>> Sent: Thursday, August 25, 2016 3:00 PM
>> To: Xu, HuilongX; dts@dpdk.org
>> Subject: RE: [dts] [PATCH V1] fix vxlan failed case
>>
>> Thanks for clear this.
>> There's one open discussion for vector mode switch in DTS.
>> One option is use testpmd parameter "enable-rx-cksum". It work on ixgbe
>> and i40e, but this method maybe invalid in later release.
>> Another option is just like patch,  we switch between vector and scatter
>> pmd by configuration file. Between the switch, it will take long time
>> for recompile dpdk.
>> There's another way is that we build different kinds of testpmd
>> applications like vector/legacy/scatter. It can skip build between
>> switch modes.
>>
>> Marvin,
>>
>>> -----Original Message-----
>>> From: Xu, HuilongX
>>> Sent: Thursday, August 25, 2016 2:42 PM
>>> To: Liu, Yong; dts@dpdk.org
>>> Subject: RE: [dts] [PATCH V1] fix vxlan failed case
>>>
>>> Hi yong,
>>> Only packet type detect case need without VEC PMD. Other cases support
>>> with VEC PMD and without VEC PMD.
>>> So for every packet type detect case need re-compile dpdk when we test
>>> with VEC PMD.
>>> Thanks a lot
>>>
>>>
>>>> -----Original Message-----
>>>> From: Liu, Yong
>>>> Sent: Thursday, August 25, 2016 2:09 PM
>>>> To: Xu, HuilongX; dts@dpdk.org
>>>> Subject: Re: [dts] [PATCH V1] fix vxlan failed case
>>>>
>>>> Thanks huilong, two comments.
>>>> 1. no need to change the setting in all cases. Only one time in
>>>> set_up_all is enough.
>>>> 2. Nvgre patch has been merged, please send out patch only for vxlan
>>>> suite.
>>>>
>>>> On 08/24/2016 02:51 PM, xu,huilong wrote:
>>>>>        def test_vxlan_ipv6_detect(self):
>>>>>            """
>>>>>            verify vxlan packet detection with ipv6 header
>>>>>            """
>>>>> +        out = self.dut.send_expect("cat config/common_base", "]#
>> ",
>>>> 10)
>>>>> +        src_vec_model = re.findall("%s=." % self.compile_switch,
>>>> out)[0][-1]
>>>>> +        if src_vec_model == 'y':
>>>>> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" %
>>>> self.compile_switch
>>>>> +                                + "%s=n/' config/common_base" %
>>>> self.compile_switch, "# ", 30)
>>>>> +            self.dut.skip_setup = False
>>>>> +            self.dut.build_install_dpdk(self.target)
>>>>> +
>>>>>            pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n
>> " +
>>>> \
>>>>>                "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" +
>> \
>>>>>                " --nb-cores=4 --portmask=%(PORT)s --txqflags=0x0"
>>>>> @@ -596,6 +624,14 @@ class TestVxlan(TestCase,
>> IxiaPacketGenerator):
>>>>>            out = self.dut.send_expect("stop", "testpmd>", 10)
>>>>>            self.dut.send_expect("quit", "#", 10)
>>>>>
>>>>> +        out = self.dut.send_expect("cat config/common_base", "]#
>> ",
>>>> 10)
>>>>> +        dst_vec_model = re.findall("%s=." % self.compile_switch,
>>>> out)[0][-1]
>>>>> +        if src_vec_model != dst_vec_model:
>>>>> +            self.dut.send_expect("sed -i -e 's/%s=.*$/" %
>>>> self.compile_switch
>>>>> +                                + "%s=%s/' config/common_base" %
>>>> (self.compile_switch, src_vec_model), "# ", 30)
>>>>> +            self.dut.skip_setup = False
>>>>> +            self.dut.build_install_dpdk(self.target)
>>>>> +
>>>>>        def test_vxlan_ipv4_checksum_offload(self):
>>>>>            """
>>>>>            verify vxlan packet checksum offload
>>>>> -- 1.9.3

      reply	other threads:[~2016-09-08  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  6:51 xu,huilong
2016-08-25  6:09 ` Liu, Yong
2016-08-25  6:42   ` Xu, HuilongX
2016-08-25  7:00     ` Liu, Yong
2016-08-25  7:09       ` Xu, HuilongX
2016-09-08  8:04         ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D11BA4.8030505@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).