From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3149691F1 for ; Thu, 8 Sep 2016 10:02:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 08 Sep 2016 01:02:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,298,1470726000"; d="scan'208";a="1026751821" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga001.jf.intel.com with ESMTP; 08 Sep 2016 01:02:13 -0700 Message-ID: <57D11BA4.8030505@intel.com> Date: Thu, 08 Sep 2016 16:04:52 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Xu, HuilongX" , "dts@dpdk.org" References: <1472021516-27491-1-git-send-email-huilongx.xu@intel.com> <57BE8B85.3090708@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E22275456@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] fix vxlan failed case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 08:02:17 -0000 OK, merged in this temporary solution. On 08/25/2016 03:09 PM, Xu, HuilongX wrote: > Hi yong, > I think, dts framework should compile many times for different compile switch. > Then case should choose different dpdk APP for test. > Could you merge this patch fist, and we can submit a new patch for dts framework compile many dpdk with different compile switch. > Thanks a lot > >> -----Original Message----- >> From: Liu, Yong >> Sent: Thursday, August 25, 2016 3:00 PM >> To: Xu, HuilongX; dts@dpdk.org >> Subject: RE: [dts] [PATCH V1] fix vxlan failed case >> >> Thanks for clear this. >> There's one open discussion for vector mode switch in DTS. >> One option is use testpmd parameter "enable-rx-cksum". It work on ixgbe >> and i40e, but this method maybe invalid in later release. >> Another option is just like patch, we switch between vector and scatter >> pmd by configuration file. Between the switch, it will take long time >> for recompile dpdk. >> There's another way is that we build different kinds of testpmd >> applications like vector/legacy/scatter. It can skip build between >> switch modes. >> >> Marvin, >> >>> -----Original Message----- >>> From: Xu, HuilongX >>> Sent: Thursday, August 25, 2016 2:42 PM >>> To: Liu, Yong; dts@dpdk.org >>> Subject: RE: [dts] [PATCH V1] fix vxlan failed case >>> >>> Hi yong, >>> Only packet type detect case need without VEC PMD. Other cases support >>> with VEC PMD and without VEC PMD. >>> So for every packet type detect case need re-compile dpdk when we test >>> with VEC PMD. >>> Thanks a lot >>> >>> >>>> -----Original Message----- >>>> From: Liu, Yong >>>> Sent: Thursday, August 25, 2016 2:09 PM >>>> To: Xu, HuilongX; dts@dpdk.org >>>> Subject: Re: [dts] [PATCH V1] fix vxlan failed case >>>> >>>> Thanks huilong, two comments. >>>> 1. no need to change the setting in all cases. Only one time in >>>> set_up_all is enough. >>>> 2. Nvgre patch has been merged, please send out patch only for vxlan >>>> suite. >>>> >>>> On 08/24/2016 02:51 PM, xu,huilong wrote: >>>>> def test_vxlan_ipv6_detect(self): >>>>> """ >>>>> verify vxlan packet detection with ipv6 header >>>>> """ >>>>> + out = self.dut.send_expect("cat config/common_base", "]# >> ", >>>> 10) >>>>> + src_vec_model = re.findall("%s=." % self.compile_switch, >>>> out)[0][-1] >>>>> + if src_vec_model == 'y': >>>>> + self.dut.send_expect("sed -i -e 's/%s=.*$/" % >>>> self.compile_switch >>>>> + + "%s=n/' config/common_base" % >>>> self.compile_switch, "# ", 30) >>>>> + self.dut.skip_setup = False >>>>> + self.dut.build_install_dpdk(self.target) >>>>> + >>>>> pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n >> " + >>>> \ >>>>> "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + >> \ >>>>> " --nb-cores=4 --portmask=%(PORT)s --txqflags=0x0" >>>>> @@ -596,6 +624,14 @@ class TestVxlan(TestCase, >> IxiaPacketGenerator): >>>>> out = self.dut.send_expect("stop", "testpmd>", 10) >>>>> self.dut.send_expect("quit", "#", 10) >>>>> >>>>> + out = self.dut.send_expect("cat config/common_base", "]# >> ", >>>> 10) >>>>> + dst_vec_model = re.findall("%s=." % self.compile_switch, >>>> out)[0][-1] >>>>> + if src_vec_model != dst_vec_model: >>>>> + self.dut.send_expect("sed -i -e 's/%s=.*$/" % >>>> self.compile_switch >>>>> + + "%s=%s/' config/common_base" % >>>> (self.compile_switch, src_vec_model), "# ", 30) >>>>> + self.dut.skip_setup = False >>>>> + self.dut.build_install_dpdk(self.target) >>>>> + >>>>> def test_vxlan_ipv4_checksum_offload(self): >>>>> """ >>>>> verify vxlan packet checksum offload >>>>> -- 1.9.3