test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Cc: "xu,huilong" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] remove ivshmem test suite
Date: Thu, 08 Sep 2016 16:09:03 +0800	[thread overview]
Message-ID: <57D11C9F.4090001@intel.com> (raw)
In-Reply-To: <1473321061-7984-1-git-send-email-gangx.xu@intel.com>

Thanks, applied. Ivshmem removed from dpdk by patch 
http://dpdk.org/dev/patchwork/patch/15051.

On 09/08/2016 03:51 PM, xu,gang wrote:
> From: "xu,huilong" <huilongx.xu@intel.com>
>
> dpdk not support ivshmem target already
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   executions/execution_smoke.cfg              |  1 -
>   test_plans/unit_tests_ivshmem_test_plan.rst | 54 -----------------
>   tests/TestSuite_unit_tests_ivshmem.py       | 93 -----------------------------
>   3 files changed, 148 deletions(-)
>   delete mode 100644 test_plans/unit_tests_ivshmem_test_plan.rst
>   delete mode 100644 tests/TestSuite_unit_tests_ivshmem.py
>
> diff --git a/executions/execution_smoke.cfg b/executions/execution_smoke.cfg
> index 5012599..9e5d2e6 100644
> --- a/executions/execution_smoke.cfg
> +++ b/executions/execution_smoke.cfg
> @@ -5,7 +5,6 @@ test_suites=
>       unit_tests_cmdline,
>       unit_tests_eal,
>       unit_tests_dump,
> -    unit_tests_ivshmem,
>       unit_tests_kni,
>       unit_tests_lpm,
>       unit_tests_mbuf,
> diff --git a/test_plans/unit_tests_ivshmem_test_plan.rst b/test_plans/unit_tests_ivshmem_test_plan.rst
> deleted file mode 100644
> index b393b19..0000000
> --- a/test_plans/unit_tests_ivshmem_test_plan.rst
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -.. Copyright (c) <2014>, Intel Corporation
> -   All rights reserved.
> -
> -   Redistribution and use in source and binary forms, with or without
> -   modification, are permitted provided that the following conditions
> -   are met:
> -
> -   - Redistributions of source code must retain the above copyright
> -     notice, this list of conditions and the following disclaimer.
> -
> -   - Redistributions in binary form must reproduce the above copyright
> -     notice, this list of conditions and the following disclaimer in
> -     the documentation and/or other materials provided with the
> -     distribution.
> -
> -   - Neither the name of Intel Corporation nor the names of its
> -     contributors may be used to endorse or promote products derived
> -     from this software without specific prior written permission.
> -
> -   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> -   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> -   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> -   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> -   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> -   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> -   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> -   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> -   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> -   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> -   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> -   OF THE POSSIBILITY OF SUCH DAMAGE.
> -
> -================
> -Ivshmem Autotest
> -================
> -
> -This is the test plan for the Intel® DPDK Inter-VM shared memory feature.
> -
> -This section explains how to run the unit tests for ivshmem. The test can be
> -launched independently using the command line interface.
> -This test is implemented as a ivshmem linuxapp environment application.
> -
> -The complete test suite is launched automatically using a python-expect
> -script (launched using ``make test``) that sends commands to
> -the application and checks the results. A test report is displayed on
> -stdout.
> -
> -The steps to run the unit test manually are as follow::
> -
> -  # make -C ./app/test/
> -  # ./app/test/test -n 1 -c ffff
> -  RTE>> ivshmem_autotest
> -
> -The final output of the test has to be "Test OK"
> \ No newline at end of file
> diff --git a/tests/TestSuite_unit_tests_ivshmem.py b/tests/TestSuite_unit_tests_ivshmem.py
> deleted file mode 100644
> index 31e8902..0000000
> --- a/tests/TestSuite_unit_tests_ivshmem.py
> +++ /dev/null
> @@ -1,93 +0,0 @@
> -# BSD LICENSE
> -#
> -# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> -# All rights reserved.
> -#
> -# Redistribution and use in source and binary forms, with or without
> -# modification, are permitted provided that the following conditions
> -# are met:
> -#
> -#   * Redistributions of source code must retain the above copyright
> -#     notice, this list of conditions and the following disclaimer.
> -#   * Redistributions in binary form must reproduce the above copyright
> -#     notice, this list of conditions and the following disclaimer in
> -#     the documentation and/or other materials provided with the
> -#     distribution.
> -#   * Neither the name of Intel Corporation nor the names of its
> -#     contributors may be used to endorse or promote products derived
> -#     from this software without specific prior written permission.
> -#
> -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> -
> -"""
> -DPDK Test suite.
> -
> -Run Inter-VM share memory autotests
> -"""
> -
> -
> -from test_case import TestCase
> -
> -#
> -#
> -# Test class.
> -#
> -
> -
> -class TestUnitTestsIvshmem(TestCase):
> -
> -    #
> -    #
> -    #
> -    # Test cases.
> -    #
> -
> -    def set_up_all(self):
> -        """
> -        Run at the start of each test suite.
> -        """
> -        [arch, machine, env, toolchain] = self.dut.target.split('-')
> -        self.target = "%s-%s-%s-%s" % (arch, "ivshmem", env, toolchain)
> -        self.verify(arch == "x86_64", "ivshmem only support x86_64")
> -        self.dut.build_install_dpdk(self.target)
> -
> -    def set_up(self):
> -        """
> -        Run before each test case.
> -        Nothing to do here.
> -        """
> -        pass
> -
> -    def test_ivshmem(self):
> -        """
> -        Run Inter-VM share memory test.
> -        """
> -        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % (self.target), "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("ivshmem_autotest", "RTE>>", 120)
> -        self.dut.send_expect("quit", "# ")
> -        self.verify("Test OK" in out, "Test failed")
> -
> -    def tear_down(self):
> -        """
> -        Run after each test case.
> -        Nothing to do here.
> -        """
> -        pass
> -
> -    def tear_down_all(self):
> -        """
> -        Run after each test suite.
> -        Remove ivshmem tempory folder
> -        """
> -        self.dut.send_expect("rm -rf " + self.target, "#")
> -        pass

  reply	other threads:[~2016-09-08  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08  7:51 xu,gang
2016-09-08  8:09 ` Liu, Yong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-09-08  1:58 xu,huilong
2016-09-08  6:49 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D11C9F.4090001@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).