test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] modify the test suite ieee1588
@ 2016-09-20  8:28 xu,gang
  2016-09-21  0:21 ` Xu, HuilongX
  2016-09-21  7:34 ` Liu, Yong
  0 siblings, 2 replies; 3+ messages in thread
From: xu,gang @ 2016-09-20  8:28 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_ieee1588.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index bfbb23b..7976c9f 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
         self.tester.scapy_append('time.sleep(1)')
 
         self.tester.scapy_execute()
+        time.sleep(10)
         out = self.tester.scapy_get_result()
         self.verify("0x88f7" in out, "Ether type is not PTP")
         # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] modify the test suite ieee1588
  2016-09-20  8:28 [dts] [PATCH V1] modify the test suite ieee1588 xu,gang
@ 2016-09-21  0:21 ` Xu, HuilongX
  2016-09-21  7:34 ` Liu, Yong
  1 sibling, 0 replies; 3+ messages in thread
From: Xu, HuilongX @ 2016-09-21  0:21 UTC (permalink / raw)
  To: Xu, GangX, dts; +Cc: Xu, GangX

Acked-by:huilong <huilongx.xu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, September 20, 2016 4:29 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] modify the test suite ieee1588
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_ieee1588.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index bfbb23b..7976c9f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
>          self.tester.scapy_append('time.sleep(1)')
> 
>          self.tester.scapy_execute()
> +        time.sleep(10)
>          out = self.tester.scapy_get_result()
>          self.verify("0x88f7" in out, "Ether type is not PTP")
>          # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] modify the test suite ieee1588
  2016-09-20  8:28 [dts] [PATCH V1] modify the test suite ieee1588 xu,gang
  2016-09-21  0:21 ` Xu, HuilongX
@ 2016-09-21  7:34 ` Liu, Yong
  1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2016-09-21  7:34 UTC (permalink / raw)
  To: xu,gang, dts

Gang, please give the reason for waiting 10 seconds. Wait ten seconds 
for sniff packet look like meaningless.

On 09/20/2016 04:28 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_ieee1588.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index bfbb23b..7976c9f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
>           self.tester.scapy_append('time.sleep(1)')
>   
>           self.tester.scapy_execute()
> +        time.sleep(10)
>           out = self.tester.scapy_get_result()
>           self.verify("0x88f7" in out, "Ether type is not PTP")
>           # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-21  7:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20  8:28 [dts] [PATCH V1] modify the test suite ieee1588 xu,gang
2016-09-21  0:21 ` Xu, HuilongX
2016-09-21  7:34 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).