From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id E35205320
 for <dts@dpdk.org>; Wed, 21 Sep 2016 09:44:19 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga103.fm.intel.com with ESMTP; 21 Sep 2016 00:44:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; d="scan'208";a="12044150"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga004.jf.intel.com with ESMTP; 21 Sep 2016 00:44:17 -0700
Message-ID: <57E23B11.30609@intel.com>
Date: Wed, 21 Sep 2016 15:47:29 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
References: <1474442404-24219-1-git-send-email-gangx.xu@intel.com>
In-Reply-To: <1474442404-24219-1-git-send-email-gangx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH V1] fix enable and disable ipv6 on FreeBSD
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2016 07:44:20 -0000

Thanks gang. Applied into master branch.

On 09/21/2016 03:20 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   nics/net_device.py | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/nics/net_device.py b/nics/net_device.py
> index 39bd4e5..bbe4bed 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -422,7 +422,11 @@ class NetDevice(object):
>               self.__send_expect("ifconfig %s up" % intf, "# ")
>   
>       def enable_ipv6_freebsd(self, intf):
> -        pass
> +        self.__send_expect("sysctl net.ipv6.conf.%s.disable_ipv6=0" %
> +                           intf, "# ")
> +        self.__send_expect("ifconfig %s down" % intf, "# ")
> +        self.__send_expect("ifconfig %s up" % intf, "# ")
> +
>   
>       @nic_has_driver
>       def disable_ipv6(self):
> @@ -443,7 +447,10 @@ class NetDevice(object):
>                              intf, "# ")
>   
>       def disable_ipv6_freebsd(self, intf):
> -        pass
> +        self.__send_expect("sysctl net.ipv6.conf.%s.disable_ipv6=1" %
> +                           intf, "# ")
> +        self.__send_expect("ifconfig %s down" % intf, "# ")
> +        self.__send_expect("ifconfig %s up" % intf, "# ")
>   
>       @nic_has_driver
>       def get_ipv6_addr(self):