test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1 2/4] fix TestSuite unit_tests_lpm
Date: Wed, 21 Sep 2016 16:01:05 +0800	[thread overview]
Message-ID: <57E23E41.1010608@intel.com> (raw)
In-Reply-To: <1474442404-24219-3-git-send-email-gangx.xu@intel.com>

Hi gang, test suite is not the right instance to handle hugepage. We 
have planned to let unified module to handle this.
My suggestion is that just increased default FreeBSD huge page memory 
size in framework.
And warning that huge page is insufficient in linux OS.

On 09/21/2016 03:20 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_lpm.py | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_lpm.py b/tests/TestSuite_unit_tests_lpm.py
> index dadb492..253cbb4 100644
> --- a/tests/TestSuite_unit_tests_lpm.py
> +++ b/tests/TestSuite_unit_tests_lpm.py
> @@ -83,16 +83,19 @@ class TestUnitTestsLpmIpv6(TestCase):
>           """
>           [arch, machine, env, toolchain] = self.target.split('-')
>           self.verify(arch == "x86_64", "lpm6 request huge memory")
> -
> -        hugepage_ori = self.dut.get_total_huge_pages()
> -        self.dut.set_huge_pages(4096)
> -        hugepage_num = self.dut.get_total_huge_pages()
> -        self.verify(hugepage_num >= 4096, "failed to request huge memory")
> +        if env == 'bsdapp':
> +            self.dut.send_expect("kenv hw.contigmem.num_buffers=4", "#", 60)
> +        else:
> +            hugepage_ori = self.dut.get_total_huge_pages()
> +            page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}' /proc/meminfo", "# ")
> +            if hugepage_ori * int(page_size) <= 4096 * 2048:
> +                self.dut.set_huge_pages(4096)
> +                hugepage_num = self.dut.get_total_huge_pages()
> +                self.verify(hugepage_num >= 4096, "failed to request huge memory")
>   
>           self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
>           out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
>           self.dut.send_expect("quit", "# ")
> -        self.dut.set_huge_pages(hugepage_ori)
>           self.verify("Test OK" in out, "Test failed")
>   
>       def tear_down(self):

  reply	other threads:[~2016-09-21  7:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  7:20 [dts] [PATCH V1] fix enable and disable ipv6 on FreeBSD xu,gang
2016-09-21  7:20 ` [dts] [PATCH V1 1/4] fix test suite coremask xu,gang
2016-09-21  7:51   ` Liu, Yong
2016-09-21  7:20 ` [dts] [PATCH V1 2/4] fix TestSuite unit_tests_lpm xu,gang
2016-09-21  8:01   ` Liu, Yong [this message]
2016-09-21  7:20 ` [dts] [PATCH V1 3/4] fix TestSuite unit_tests_mbuf xu,gang
2016-09-21  7:45   ` Liu, Yong
2016-09-21  7:20 ` [dts] [PATCH V1 4/4] fix TestSuite unit_tests_ringpmd xu,gang
2016-09-21  7:23   ` Liu, Yong
2016-09-21  7:47 ` [dts] [PATCH V1] fix enable and disable ipv6 on FreeBSD Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E23E41.1010608@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).