test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V2 1/5] fix TestSuite ieee1588
Date: Thu, 22 Sep 2016 09:28:18 +0800	[thread overview]
Message-ID: <57E333B2.4070701@intel.com> (raw)
In-Reply-To: <1474453120-24986-1-git-send-email-gangx.xu@intel.com>

Hi gang, these patches have no relationships to each other. There's no 
need to create one patch set for them. You can send patches out one by one.
If scapy sniff function is not stable, you can try to use packet module 
for packet sniff. Again, we need the root cause of this issue.

On 09/21/2016 06:18 PM, xu,gang wrote:
> wait for subprocess end in scapy_execute()
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_ieee1588.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index bfbb23b..7976c9f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
>           self.tester.scapy_append('time.sleep(1)')
>   
>           self.tester.scapy_execute()
> +        time.sleep(10)
>           out = self.tester.scapy_get_result()
>           self.verify("0x88f7" in out, "Ether type is not PTP")
>           # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")

      parent reply	other threads:[~2016-09-22  1:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 10:18 xu,gang
2016-09-21 10:18 ` [dts] [PATCH V2 2/5] fix TestSuite unit_tests_mbuf xu,gang
2016-09-22  1:05   ` Liu, Yong
2016-09-21 10:18 ` [dts] [PATCH V2 3/5] fix TestSuite unit_tests_ringpmd xu,gang
2016-09-22  1:02   ` Liu, Yong
2016-09-21 10:18 ` [dts] [PATCH V2 4/5] fix TestSuite coremask xu,gang
2016-09-22  1:04   ` Liu, Yong
2016-09-21 10:18 ` [dts] [PATCH V2 5/5] increased huge page memory size on FreeBSD xu,gang
2016-09-22  1:16   ` Liu, Yong
2016-09-22  1:28 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E333B2.4070701@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).