From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A14F82931 for ; Thu, 22 Sep 2016 03:25:11 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP; 21 Sep 2016 18:25:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,376,1470726000"; d="scan'208";a="12361881" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga004.jf.intel.com with ESMTP; 21 Sep 2016 18:25:09 -0700 Message-ID: <57E333B2.4070701@intel.com> Date: Thu, 22 Sep 2016 09:28:18 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,gang" , dts@dpdk.org References: <1474453120-24986-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1474453120-24986-1-git-send-email-gangx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V2 1/5] fix TestSuite ieee1588 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 01:25:12 -0000 Hi gang, these patches have no relationships to each other. There's no need to create one patch set for them. You can send patches out one by one. If scapy sniff function is not stable, you can try to use packet module for packet sniff. Again, we need the root cause of this issue. On 09/21/2016 06:18 PM, xu,gang wrote: > wait for subprocess end in scapy_execute() > > Signed-off-by: xu,gang > --- > tests/TestSuite_ieee1588.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py > index bfbb23b..7976c9f 100644 > --- a/tests/TestSuite_ieee1588.py > +++ b/tests/TestSuite_ieee1588.py > @@ -92,6 +92,7 @@ class TestIeee1588(TestCase): > self.tester.scapy_append('time.sleep(1)') > > self.tester.scapy_execute() > + time.sleep(10) > out = self.tester.scapy_get_result() > self.verify("0x88f7" in out, "Ether type is not PTP") > # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")