From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 420E511DE
 for <dts@dpdk.org>; Thu, 29 Sep 2016 07:12:47 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga104.fm.intel.com with ESMTP; 28 Sep 2016 22:12:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,413,1470726000"; d="scan'208";a="14387677"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2016 22:12:45 -0700
Message-ID: <57ECA36E.90901@intel.com>
Date: Thu, 29 Sep 2016 13:15:26 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
References: <1475113939-31884-1-git-send-email-gangx.xu@intel.com>
In-Reply-To: <1475113939-31884-1-git-send-email-gangx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH V1] fix start error in dts
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 05:12:47 -0000

Thanks, applied.

On 09/29/2016 09:52 AM, xu,gang wrote:
> it's in settings don't need to reference
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/settings.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/framework/settings.py b/framework/settings.py
> index 0e18a15..1cfb6c1 100644
> --- a/framework/settings.py
> +++ b/framework/settings.py
> @@ -275,14 +275,14 @@ def accepted_nic(pci_id):
>       it is selected in the execution file, otherwise it returns False.
>       """
>       nic = load_global_setting(HOST_NIC_SETTING)
> -    if pci_id not in settings.NICS.values():
> +    if pci_id not in NICS.values():
>           return False
>   
>       if nic is 'any':
>           return True
>   
>       else:
> -        if pci_id == settings.NICS[nic]:
> +        if pci_id == NICS[nic]:
>               return True
>   
>       return False