test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm on FreeBSD
Date: Thu, 29 Sep 2016 13:30:05 +0800	[thread overview]
Message-ID: <57ECA6DD.9020903@intel.com> (raw)
In-Reply-To: <1475052328-31142-2-git-send-email-gangx.xu@intel.com>

Applied, please make submit title and log more readable.

On 09/28/2016 04:45 PM, xu,gang wrote:
> build branch for FreeBSD in TestSuite unit_tests_lpm
> old code not support FreeBSD
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_lpm.py | 17 +++++++++++------
>   1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_lpm.py b/tests/TestSuite_unit_tests_lpm.py
> index dadb492..d892916 100644
> --- a/tests/TestSuite_unit_tests_lpm.py
> +++ b/tests/TestSuite_unit_tests_lpm.py
> @@ -83,16 +83,21 @@ class TestUnitTestsLpmIpv6(TestCase):
>           """
>           [arch, machine, env, toolchain] = self.target.split('-')
>           self.verify(arch == "x86_64", "lpm6 request huge memory")
> -
> -        hugepage_ori = self.dut.get_total_huge_pages()
> -        self.dut.set_huge_pages(4096)
> -        hugepage_num = self.dut.get_total_huge_pages()
> -        self.verify(hugepage_num >= 4096, "failed to request huge memory")
> +        if env == 'bsdapp':
> +            pass
> +        else:
> +            hugepage_ori = self.dut.get_total_huge_pages()
> +            self.dut.set_huge_pages(4096)
> +            hugepage_num = self.dut.get_total_huge_pages()
> +            self.verify(hugepage_num >= 4096, "failed to request huge memory")
>   
>           self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
>           out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
>           self.dut.send_expect("quit", "# ")
> -        self.dut.set_huge_pages(hugepage_ori)
> +        if env == 'bsdapp':
> +            pass
> +        else:
> +            self.dut.set_huge_pages(hugepage_ori)
>           self.verify("Test OK" in out, "Test failed")
>   
>       def tear_down(self):

  reply	other threads:[~2016-09-29  5:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  8:45 [dts] [PATCH V1 1/3] fix TestSuite coremask " xu,gang
2016-09-28  8:45 ` [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm " xu,gang
2016-09-29  5:30   ` Liu, Yong [this message]
2016-09-28  8:45 ` [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf " xu,gang
2016-09-29  5:18   ` Liu, Yong
2016-09-29  5:26 ` [dts] [PATCH V1 1/3] fix TestSuite coremask " Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ECA6DD.9020903@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).