From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EF450D4E0 for ; Wed, 11 Jan 2017 09:02:36 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 11 Jan 2017 00:02:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="807538942" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2017 00:02:34 -0800 Message-ID: <5875E598.2030602@intel.com> Date: Wed, 11 Jan 2017 15:58:16 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,huilong" , dts@dpdk.org References: <1483949395-34032-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1483949395-34032-1-git-send-email-huilongx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [patch V1] fix ifconfig and ping test case in kni test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 08:02:37 -0000 Thanks, applied. On 01/09/2017 04:09 PM, xu,huilong wrote: > chang list: > 1. set virtual interface down, before test ifconfig up function, because sometime the virtual interface stats is up, when creat it. > 2. remove ipv6 address check, when virtual interface create. because different os, ipv6 default not enable. should add ipv6 address by slef. > 3. remove ping virtual interface by self. some os not support this test, eg RHEL. > > Signed-off-by: xu,huilong > --- > tests/TestSuite_kni.py | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py > index 00f1e25..0825903 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -469,17 +469,14 @@ class TestKni(TestCase): > for port in self.config['ports']: > virtual_interface = self.virtual_interface_name(port) > > - # Set up > + # some time, the virtual interface stats is up when it create > + # so should set down before set up. > + self.dut.send_expect( > + "ifconfig %s down" % virtual_interface, "# ") > out = self.dut.send_expect( > "ifconfig %s up" % virtual_interface, "# ") > self.verify("Configure network interface of %d up" % > port in out, "ifconfig up not supported") > - > - out = self.dut.send_expect( > - "ip -family inet6 address show dev %s" % virtual_interface, "# ") > - self.verify( > - "inet6 " in out, "ifconfig up the port_virtual_interaces not support") > - > # Add an IPv6 address > out = self.dut.send_expect( > "ifconfig %s add fe80::%d" % (virtual_interface, port + 1), "# ") > @@ -549,11 +546,6 @@ class TestKni(TestCase): > virtual_interface = self.virtual_interface_name(port) > > out = self.dut.send_expect( > - "ping -w 2 -I %s 192.168.%d.1" % (virtual_interface, port), "# ", 10) > - self.verify("64 bytes from 192.168.%d.1:" % > - port in out, "ping not supported") > - > - out = self.dut.send_expect( > "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10) > self.verify("64 bytes from 192.168.%d.2:" % > port in out, "ping not supported")