test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Rami Rosen <rami.rosen@intel.com>
Cc: dts@dpdk.org, sunx.jiajia@intel.com
Subject: Re: [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite.
Date: Wed, 11 Jan 2017 16:21:25 +0800	[thread overview]
Message-ID: <5875EB05.1030706@intel.com> (raw)
In-Reply-To: <1483862924-15626-1-git-send-email-rami.rosen@intel.com>

Thanks Remi to fix it. Applied into master branch.

On 01/08/2017 04:08 PM, Rami Rosen wrote:
> This patch fixes a typo in sriov kvm TestSuite
> (use "self" instrad of "slef").
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   tests/TestSuite_sriov_kvm.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index 41af4dd..b74da5e 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -469,7 +469,7 @@ class TestSriovKvm(TestCase):
>               self.vm2.stop()
>               self.vm2 = None
>   
> -        if getattr(slef, 'vm3', None):
> +        if getattr(self, 'vm3', None):
>               self.vm3.stop()
>               self.vm3 = None
>   
> @@ -482,7 +482,7 @@ class TestSriovKvm(TestCase):
>               self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
>               port = self.ports_info[self.used_dut_port]['port']
>               port.bind_driver('igb_uio')
> -            slef.used_dut_port = None
> +            self.used_dut_port = None
>   
>           for port_id in self.dut_ports:
>               port = self.dut.ports_info[port_id]['port']
> @@ -1247,7 +1247,7 @@ class TestSriovKvm(TestCase):
>               self.destroy_2vm_2vf_env()
>   
>           if self.setup_2vm_2pf_env_flag == 1:
> -            slef.destroy_2vm_2pf_env()
> +            self.destroy_2vm_2pf_env()
>   
>           if self.setup_4vm_prerequisite_flag == 1:
>               self.destroy_four_vm_common_prerequisite()

      reply	other threads:[~2017-01-11  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08  8:08 Rami Rosen
2017-01-11  8:21 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5875EB05.1030706@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=rami.rosen@intel.com \
    --cc=sunx.jiajia@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).