test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite.
@ 2017-01-08  8:08 Rami Rosen
  2017-01-11  8:21 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2017-01-08  8:08 UTC (permalink / raw)
  To: yong.liu; +Cc: dts, sunx.jiajia, Rami Rosen

This patch fixes a typo in sriov kvm TestSuite
(use "self" instrad of "slef").

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 tests/TestSuite_sriov_kvm.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index 41af4dd..b74da5e 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -469,7 +469,7 @@ class TestSriovKvm(TestCase):
             self.vm2.stop()
             self.vm2 = None
 
-        if getattr(slef, 'vm3', None):
+        if getattr(self, 'vm3', None):
             self.vm3.stop()
             self.vm3 = None
 
@@ -482,7 +482,7 @@ class TestSriovKvm(TestCase):
             self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
             port = self.ports_info[self.used_dut_port]['port']
             port.bind_driver('igb_uio')
-            slef.used_dut_port = None
+            self.used_dut_port = None
 
         for port_id in self.dut_ports:
             port = self.dut.ports_info[port_id]['port']
@@ -1247,7 +1247,7 @@ class TestSriovKvm(TestCase):
             self.destroy_2vm_2vf_env()
 
         if self.setup_2vm_2pf_env_flag == 1:
-            slef.destroy_2vm_2pf_env()
+            self.destroy_2vm_2pf_env()
 
         if self.setup_4vm_prerequisite_flag == 1:
             self.destroy_four_vm_common_prerequisite()
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite.
  2017-01-08  8:08 [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite Rami Rosen
@ 2017-01-11  8:21 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-01-11  8:21 UTC (permalink / raw)
  To: Rami Rosen; +Cc: dts, sunx.jiajia

Thanks Remi to fix it. Applied into master branch.

On 01/08/2017 04:08 PM, Rami Rosen wrote:
> This patch fixes a typo in sriov kvm TestSuite
> (use "self" instrad of "slef").
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   tests/TestSuite_sriov_kvm.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index 41af4dd..b74da5e 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -469,7 +469,7 @@ class TestSriovKvm(TestCase):
>               self.vm2.stop()
>               self.vm2 = None
>   
> -        if getattr(slef, 'vm3', None):
> +        if getattr(self, 'vm3', None):
>               self.vm3.stop()
>               self.vm3 = None
>   
> @@ -482,7 +482,7 @@ class TestSriovKvm(TestCase):
>               self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
>               port = self.ports_info[self.used_dut_port]['port']
>               port.bind_driver('igb_uio')
> -            slef.used_dut_port = None
> +            self.used_dut_port = None
>   
>           for port_id in self.dut_ports:
>               port = self.dut.ports_info[port_id]['port']
> @@ -1247,7 +1247,7 @@ class TestSriovKvm(TestCase):
>               self.destroy_2vm_2vf_env()
>   
>           if self.setup_2vm_2pf_env_flag == 1:
> -            slef.destroy_2vm_2pf_env()
> +            self.destroy_2vm_2pf_env()
>   
>           if self.setup_4vm_prerequisite_flag == 1:
>               self.destroy_four_vm_common_prerequisite()

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-11  8:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-08  8:08 [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite Rami Rosen
2017-01-11  8:21 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).