From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id B0747D59A
 for <dts@dpdk.org>; Wed, 11 Jan 2017 09:25:45 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 11 Jan 2017 00:25:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="212036527"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by fmsmga004.fm.intel.com with ESMTP; 11 Jan 2017 00:25:43 -0800
Message-ID: <5875EB05.1030706@intel.com>
Date: Wed, 11 Jan 2017 16:21:25 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rami Rosen <rami.rosen@intel.com>
CC: dts@dpdk.org, sunx.jiajia@intel.com
References: <1483862924-15626-1-git-send-email-rami.rosen@intel.com>
In-Reply-To: <1483862924-15626-1-git-send-email-rami.rosen@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH] tests: Fix a typo in sriov kvm TestSuite.
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 08:25:46 -0000

Thanks Remi to fix it. Applied into master branch.

On 01/08/2017 04:08 PM, Rami Rosen wrote:
> This patch fixes a typo in sriov kvm TestSuite
> (use "self" instrad of "slef").
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   tests/TestSuite_sriov_kvm.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index 41af4dd..b74da5e 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -469,7 +469,7 @@ class TestSriovKvm(TestCase):
>               self.vm2.stop()
>               self.vm2 = None
>   
> -        if getattr(slef, 'vm3', None):
> +        if getattr(self, 'vm3', None):
>               self.vm3.stop()
>               self.vm3 = None
>   
> @@ -482,7 +482,7 @@ class TestSriovKvm(TestCase):
>               self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
>               port = self.ports_info[self.used_dut_port]['port']
>               port.bind_driver('igb_uio')
> -            slef.used_dut_port = None
> +            self.used_dut_port = None
>   
>           for port_id in self.dut_ports:
>               port = self.dut.ports_info[port_id]['port']
> @@ -1247,7 +1247,7 @@ class TestSriovKvm(TestCase):
>               self.destroy_2vm_2vf_env()
>   
>           if self.setup_2vm_2pf_env_flag == 1:
> -            slef.destroy_2vm_2pf_env()
> +            self.destroy_2vm_2pf_env()
>   
>           if self.setup_4vm_prerequisite_flag == 1:
>               self.destroy_four_vm_common_prerequisite()