test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>,
	 "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: fix ping6 parameter to interface name for link local address
Date: Thu, 12 Jan 2017 10:25:31 +0800	[thread overview]
Message-ID: <5876E91B.2070802@intel.com> (raw)
In-Reply-To: <1484135080-25428-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com>

Thanks, applied into master branch.

On 01/11/2017 07:44 PM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> Below patch adds scope identifier for link local address of remote ports while
> probing connecting port peers, instead of using -I option in ping6 command.
>
> This was to be broken atleast in Ubuntu 16.10 as DTS tester.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> ---
>   framework/tester.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/tester.py b/framework/tester.py
> index 4f54fcd..6a873e2 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -370,7 +370,7 @@ class Tester(Crb):
>           if self.ports_info[localPort]['type'] == 'ixia':
>               return self.ixia_packet_gen.send_ping6(self.ports_info[localPort]['pci'], mac, ipv6)
>           else:
> -            return self.send_expect("ping6 -w 5 -c 5 -A -I %s %s" % (self.ports_info[localPort]['intf'], ipv6), "# ", 10)
> +            return self.send_expect("ping6 -w 5 -c 5 -A %s%%%s" % (ipv6, self.ports_info[localPort]['intf']), "# ", 10)
>   
>       def get_port_numa(self, port):
>           """

      reply	other threads:[~2017-01-12  2:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 11:44 Gowrishankar
2017-01-12  2:25 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5876E91B.2070802@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gowrishankar.m@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).