test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] framework: fix ping6 parameter to interface name for link local address
@ 2017-01-11 11:44 Gowrishankar
  2017-01-12  2:25 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Gowrishankar @ 2017-01-11 11:44 UTC (permalink / raw)
  To: dts; +Cc: Gowrishankar Muthukrishnan

From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>

Below patch adds scope identifier for link local address of remote ports while
probing connecting port peers, instead of using -I option in ping6 command.

This was to be broken atleast in Ubuntu 16.10 as DTS tester.

Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
 framework/tester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/tester.py b/framework/tester.py
index 4f54fcd..6a873e2 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -370,7 +370,7 @@ class Tester(Crb):
         if self.ports_info[localPort]['type'] == 'ixia':
             return self.ixia_packet_gen.send_ping6(self.ports_info[localPort]['pci'], mac, ipv6)
         else:
-            return self.send_expect("ping6 -w 5 -c 5 -A -I %s %s" % (self.ports_info[localPort]['intf'], ipv6), "# ", 10)
+            return self.send_expect("ping6 -w 5 -c 5 -A %s%%%s" % (ipv6, self.ports_info[localPort]['intf']), "# ", 10)
 
     def get_port_numa(self, port):
         """
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] framework: fix ping6 parameter to interface name for link local address
  2017-01-11 11:44 [dts] [PATCH] framework: fix ping6 parameter to interface name for link local address Gowrishankar
@ 2017-01-12  2:25 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-01-12  2:25 UTC (permalink / raw)
  To: Gowrishankar, dts

Thanks, applied into master branch.

On 01/11/2017 07:44 PM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> Below patch adds scope identifier for link local address of remote ports while
> probing connecting port peers, instead of using -I option in ping6 command.
>
> This was to be broken atleast in Ubuntu 16.10 as DTS tester.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> ---
>   framework/tester.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/tester.py b/framework/tester.py
> index 4f54fcd..6a873e2 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -370,7 +370,7 @@ class Tester(Crb):
>           if self.ports_info[localPort]['type'] == 'ixia':
>               return self.ixia_packet_gen.send_ping6(self.ports_info[localPort]['pci'], mac, ipv6)
>           else:
> -            return self.send_expect("ping6 -w 5 -c 5 -A -I %s %s" % (self.ports_info[localPort]['intf'], ipv6), "# ", 10)
> +            return self.send_expect("ping6 -w 5 -c 5 -A %s%%%s" % (ipv6, self.ports_info[localPort]['intf']), "# ", 10)
>   
>       def get_port_numa(self, port):
>           """

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-12  2:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-11 11:44 [dts] [PATCH] framework: fix ping6 parameter to interface name for link local address Gowrishankar
2017-01-12  2:25 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).