test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]framework: fix suites module import issue
@ 2017-01-04  3:43 yufengmx
  2017-01-04  3:43 ` [dts] [PATCH V1]framework: 'suite-dir' won't work yufengmx
  0 siblings, 1 reply; 3+ messages in thread
From: yufengmx @ 2017-01-04  3:43 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

*. suites module path should be loaded in dts/run_all, not in main.py import section 

yufengmx (1):
  framework: 'suite-dir' won't work.

 framework/main.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1]framework: 'suite-dir' won't work.
  2017-01-04  3:43 [dts] [PATCH V1]framework: fix suites module import issue yufengmx
@ 2017-01-04  3:43 ` yufengmx
  2017-01-16  2:42   ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: yufengmx @ 2017-01-04  3:43 UTC (permalink / raw)
  To: dts; +Cc: yufengmx


*. suites module path should be loaded in dts/run_all. import tests directory in main.py will
   cause suite-dir option effectless, input tests directory is always overlapped by default tests.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/main.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/main.py b/framework/main.py
index 5d7d051..a018af0 100755
--- a/framework/main.py
+++ b/framework/main.py
@@ -43,7 +43,7 @@ os.chdir("../")
 cwd = os.getcwd()
 sys.path.append(cwd + '/nics')
 sys.path.append(cwd + '/framework')
-sys.path.append(cwd + '/tests')
+#sys.path.append(cwd + '/tests') # suites module path should be loaded in dts/run_all, not here
 sys.path.append(cwd + '/dep')
 
 import dts
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]framework: 'suite-dir' won't work.
  2017-01-04  3:43 ` [dts] [PATCH V1]framework: 'suite-dir' won't work yufengmx
@ 2017-01-16  2:42   ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2017-01-16  2:42 UTC (permalink / raw)
  To: yufengmx, dts

Thanks, applied into master branch.

On 01/04/2017 11:43 AM, yufengmx wrote:
> . suites module path should be loaded in dts/run_all. import tests directory in main.py will
>     cause suite-dir option effectless, input tests directory is always overlapped by default tests.
>
> Signed-off-by: yufengmx<yufengx.mo@intel.com>
> ---
>   framework/main.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-16  2:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-04  3:43 [dts] [PATCH V1]framework: fix suites module import issue yufengmx
2017-01-04  3:43 ` [dts] [PATCH V1]framework: 'suite-dir' won't work yufengmx
2017-01-16  2:42   ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).