test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH]tests vf_vlan: fix vlan function check failure.
Date: Tue, 21 Feb 2017 15:05:21 +0800	[thread overview]
Message-ID: <58ABE6B1.3010000@intel.com> (raw)
In-Reply-To: <1487658281-31664-1-git-send-email-lijuanx.a.tu@intel.com>

Thanks Lijuan, applied.

On 02/21/2017 02:24 PM, Lijuan Tu wrote:
> 1. disable promisc in vlan suite
> Fortville vlan filter and promisc filter use the same switch.
> 2. change verified infomation
> DPDK changed vlan verbose
> 3. port should bind to default driver but not igb_uio
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   tests/TestSuite_vf_vlan.py | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
> index 74930b0..1edf23d 100644
> --- a/tests/TestSuite_vf_vlan.py
> +++ b/tests/TestSuite_vf_vlan.py
> @@ -134,7 +134,7 @@ class TestVfVlan(TestCase):
>               port = self.dut.ports_info[self.used_dut_port_1]['port']
>               self.used_dut_port_1 = None
>   
> -        self.bind_nic_driver(self.dut_ports[:2], driver='igb_uio')
> +        self.bind_nic_driver(self.dut_ports[:2], driver='default')
>   
>           self.env_done = False
>   
> @@ -301,6 +301,7 @@ class TestVfVlan(TestCase):
>           self.vm0_testpmd.execute_cmd('set verbose 1')
>           self.vm0_testpmd.execute_cmd('vlan set strip on 0')
>           self.vm0_testpmd.execute_cmd('vlan set filter on 0')
> +        self.vm0_testpmd.execute_cmd("set promisc all off")
>           self.vm0_testpmd.execute_cmd('start')
>   
>           # send packet without vlan
> @@ -376,6 +377,7 @@ class TestVfVlan(TestCase):
>               vlan_hex = hex(rx_vlan)
>               self.verify("VLAN tci=%s" %
>                           vlan_hex in out, "Failed to strip vlan packet!!!")
> +            self.verify("PKT_RX_VLAN_STRIPPED" in out, "Failed to strip vlan packet!")
>   
>               self.vm0_testpmd.execute_cmd('vlan set strip off 0')
>   
> @@ -389,7 +391,7 @@ class TestVfVlan(TestCase):
>                               vlan_hex in out, "Failed to disable strip vlan!!!")
>               else:
>                   self.verify(
> -                    "VLAN tci=0x0" in out, "Failed to disable strip vlan!!!")
> +                    "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!")
>   
>           self.vm0_testpmd.quit()
>   

      reply	other threads:[~2017-02-21  7:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21  6:24 Lijuan Tu
2017-02-21  7:05 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58ABE6B1.3010000@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).