From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 008992BFF for ; Tue, 21 Feb 2017 08:12:52 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2017 23:12:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,188,1484035200"; d="scan'208";a="1100485579" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga001.jf.intel.com with ESMTP; 20 Feb 2017 23:12:24 -0800 Message-ID: <58ABE6B1.3010000@intel.com> Date: Tue, 21 Feb 2017 15:05:21 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lijuan Tu , dts@dpdk.org References: <1487658281-31664-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1487658281-31664-1-git-send-email-lijuanx.a.tu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH]tests vf_vlan: fix vlan function check failure. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 07:12:53 -0000 Thanks Lijuan, applied. On 02/21/2017 02:24 PM, Lijuan Tu wrote: > 1. disable promisc in vlan suite > Fortville vlan filter and promisc filter use the same switch. > 2. change verified infomation > DPDK changed vlan verbose > 3. port should bind to default driver but not igb_uio > > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_vf_vlan.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py > index 74930b0..1edf23d 100644 > --- a/tests/TestSuite_vf_vlan.py > +++ b/tests/TestSuite_vf_vlan.py > @@ -134,7 +134,7 @@ class TestVfVlan(TestCase): > port = self.dut.ports_info[self.used_dut_port_1]['port'] > self.used_dut_port_1 = None > > - self.bind_nic_driver(self.dut_ports[:2], driver='igb_uio') > + self.bind_nic_driver(self.dut_ports[:2], driver='default') > > self.env_done = False > > @@ -301,6 +301,7 @@ class TestVfVlan(TestCase): > self.vm0_testpmd.execute_cmd('set verbose 1') > self.vm0_testpmd.execute_cmd('vlan set strip on 0') > self.vm0_testpmd.execute_cmd('vlan set filter on 0') > + self.vm0_testpmd.execute_cmd("set promisc all off") > self.vm0_testpmd.execute_cmd('start') > > # send packet without vlan > @@ -376,6 +377,7 @@ class TestVfVlan(TestCase): > vlan_hex = hex(rx_vlan) > self.verify("VLAN tci=%s" % > vlan_hex in out, "Failed to strip vlan packet!!!") > + self.verify("PKT_RX_VLAN_STRIPPED" in out, "Failed to strip vlan packet!") > > self.vm0_testpmd.execute_cmd('vlan set strip off 0') > > @@ -389,7 +391,7 @@ class TestVfVlan(TestCase): > vlan_hex in out, "Failed to disable strip vlan!!!") > else: > self.verify( > - "VLAN tci=0x0" in out, "Failed to disable strip vlan!!!") > + "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!") > > self.vm0_testpmd.quit() >