test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] fix dpdk test app compile issue
Date: Thu, 02 Mar 2017 15:18:29 +0800	[thread overview]
Message-ID: <58B7C745.1060303@intel.com> (raw)
In-Reply-To: <1488438760-2321-1-git-send-email-huilongx.xu@intel.com>

Thanks, huilong. If I am right, this patch is for latest dpdk code and 
not work on 17.02.
Pending merge action after tag for v17.02 created.

On 03/02/2017 03:12 PM, xu,huilong wrote:
> change list:
> new dpdk code move code path and make file, default compile will not compile app test path.
> so should compile test app and copy test app to driver compile path.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   framework/project_dpdk.py | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> index e2e4b5e..7a4e4f7 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -183,6 +183,13 @@ class DPDKdut(Dut):
>   
>           # compile
>           out = self.send_expect("make -j install T=%s %s" % (target, extra_options), "# ", build_time)
> +        #should not check test app compile status, because if test compile fail,
> +        #all unit test can't exec, but others case will exec sucessfull
> +        self.send_expect("make -j -C test/", "# ", build_time)
> +        app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> +        for app in app_list:
> +            self.send_expect('cp  %s ./%s/app' % (app, target), "# ", 30)
> +
>   
>           if("Error" in out or "No rule to make" in out):
>               self.logger.error("ERROR - try without '-j'")
> @@ -191,7 +198,6 @@ class DPDKdut(Dut):
>   
>           assert ("Error" not in out), "Compilation error..."
>           assert ("No rule to make" not in out), "No rule to make error..."
> -
>       def build_install_dpdk_freebsd(self, target, extra_options):
>           """
>           Build DPDK source code on Freebsd with specified target.
> @@ -206,6 +212,13 @@ class DPDKdut(Dut):
>           out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,
>                                                                        target),
>                                  "#", 120)
> +        #should not check test app compile status, because if test compile fail,
> +        #all unit test can't exec, but others case will exec sucessfull
> +        self.send_expect("make -j -C test/ CC=gcc48", "# ", build_time)
> +
> +        app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> +        for app in app_list:
> +            self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30)
>   
>           if("Error" in out or "No rule to make" in out):
>               self.logger.error("ERROR - try without '-j'")

  reply	other threads:[~2017-03-02  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  7:12 xu,huilong
2017-03-02  7:18 ` Liu, Yong [this message]
2017-03-02  7:49   ` Xu, HuilongX
2017-03-02  8:10     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58B7C745.1060303@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).