From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E296A2B88 for ; Thu, 2 Mar 2017 08:26:10 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 01 Mar 2017 23:26:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,228,1484035200"; d="scan'208";a="63495460" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga004.jf.intel.com with ESMTP; 01 Mar 2017 23:26:09 -0800 Message-ID: <58B7C745.1060303@intel.com> Date: Thu, 02 Mar 2017 15:18:29 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,huilong" , dts@dpdk.org References: <1488438760-2321-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1488438760-2321-1-git-send-email-huilongx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] fix dpdk test app compile issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 07:26:11 -0000 Thanks, huilong. If I am right, this patch is for latest dpdk code and not work on 17.02. Pending merge action after tag for v17.02 created. On 03/02/2017 03:12 PM, xu,huilong wrote: > change list: > new dpdk code move code path and make file, default compile will not compile app test path. > so should compile test app and copy test app to driver compile path. > > Signed-off-by: xu,huilong > --- > framework/project_dpdk.py | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py > index e2e4b5e..7a4e4f7 100644 > --- a/framework/project_dpdk.py > +++ b/framework/project_dpdk.py > @@ -183,6 +183,13 @@ class DPDKdut(Dut): > > # compile > out = self.send_expect("make -j install T=%s %s" % (target, extra_options), "# ", build_time) > + #should not check test app compile status, because if test compile fail, > + #all unit test can't exec, but others case will exec sucessfull > + self.send_expect("make -j -C test/", "# ", build_time) > + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > + for app in app_list: > + self.send_expect('cp %s ./%s/app' % (app, target), "# ", 30) > + > > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > @@ -191,7 +198,6 @@ class DPDKdut(Dut): > > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error..." > - > def build_install_dpdk_freebsd(self, target, extra_options): > """ > Build DPDK source code on Freebsd with specified target. > @@ -206,6 +212,13 @@ class DPDKdut(Dut): > out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores, > target), > "#", 120) > + #should not check test app compile status, because if test compile fail, > + #all unit test can't exec, but others case will exec sucessfull > + self.send_expect("make -j -C test/ CC=gcc48", "# ", build_time) > + > + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > + for app in app_list: > + self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) > > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'")