* [dts] [PATCH V1] fix dpdk test app compile issue
@ 2017-03-02 7:12 xu,huilong
2017-03-02 7:18 ` Liu, Yong
0 siblings, 1 reply; 4+ messages in thread
From: xu,huilong @ 2017-03-02 7:12 UTC (permalink / raw)
To: dts; +Cc: xu,huilong
change list:
new dpdk code move code path and make file, default compile will not compile app test path.
so should compile test app and copy test app to driver compile path.
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
framework/project_dpdk.py | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index e2e4b5e..7a4e4f7 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -183,6 +183,13 @@ class DPDKdut(Dut):
# compile
out = self.send_expect("make -j install T=%s %s" % (target, extra_options), "# ", build_time)
+ #should not check test app compile status, because if test compile fail,
+ #all unit test can't exec, but others case will exec sucessfull
+ self.send_expect("make -j -C test/", "# ", build_time)
+ app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
+ for app in app_list:
+ self.send_expect('cp %s ./%s/app' % (app, target), "# ", 30)
+
if("Error" in out or "No rule to make" in out):
self.logger.error("ERROR - try without '-j'")
@@ -191,7 +198,6 @@ class DPDKdut(Dut):
assert ("Error" not in out), "Compilation error..."
assert ("No rule to make" not in out), "No rule to make error..."
-
def build_install_dpdk_freebsd(self, target, extra_options):
"""
Build DPDK source code on Freebsd with specified target.
@@ -206,6 +212,13 @@ class DPDKdut(Dut):
out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,
target),
"#", 120)
+ #should not check test app compile status, because if test compile fail,
+ #all unit test can't exec, but others case will exec sucessfull
+ self.send_expect("make -j -C test/ CC=gcc48", "# ", build_time)
+
+ app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
+ for app in app_list:
+ self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30)
if("Error" in out or "No rule to make" in out):
self.logger.error("ERROR - try without '-j'")
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] fix dpdk test app compile issue
2017-03-02 7:12 [dts] [PATCH V1] fix dpdk test app compile issue xu,huilong
@ 2017-03-02 7:18 ` Liu, Yong
2017-03-02 7:49 ` Xu, HuilongX
0 siblings, 1 reply; 4+ messages in thread
From: Liu, Yong @ 2017-03-02 7:18 UTC (permalink / raw)
To: xu,huilong, dts
Thanks, huilong. If I am right, this patch is for latest dpdk code and
not work on 17.02.
Pending merge action after tag for v17.02 created.
On 03/02/2017 03:12 PM, xu,huilong wrote:
> change list:
> new dpdk code move code path and make file, default compile will not compile app test path.
> so should compile test app and copy test app to driver compile path.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> framework/project_dpdk.py | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> index e2e4b5e..7a4e4f7 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -183,6 +183,13 @@ class DPDKdut(Dut):
>
> # compile
> out = self.send_expect("make -j install T=%s %s" % (target, extra_options), "# ", build_time)
> + #should not check test app compile status, because if test compile fail,
> + #all unit test can't exec, but others case will exec sucessfull
> + self.send_expect("make -j -C test/", "# ", build_time)
> + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> + for app in app_list:
> + self.send_expect('cp %s ./%s/app' % (app, target), "# ", 30)
> +
>
> if("Error" in out or "No rule to make" in out):
> self.logger.error("ERROR - try without '-j'")
> @@ -191,7 +198,6 @@ class DPDKdut(Dut):
>
> assert ("Error" not in out), "Compilation error..."
> assert ("No rule to make" not in out), "No rule to make error..."
> -
> def build_install_dpdk_freebsd(self, target, extra_options):
> """
> Build DPDK source code on Freebsd with specified target.
> @@ -206,6 +212,13 @@ class DPDKdut(Dut):
> out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,
> target),
> "#", 120)
> + #should not check test app compile status, because if test compile fail,
> + #all unit test can't exec, but others case will exec sucessfull
> + self.send_expect("make -j -C test/ CC=gcc48", "# ", build_time)
> +
> + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> + for app in app_list:
> + self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30)
>
> if("Error" in out or "No rule to make" in out):
> self.logger.error("ERROR - try without '-j'")
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] fix dpdk test app compile issue
2017-03-02 7:18 ` Liu, Yong
@ 2017-03-02 7:49 ` Xu, HuilongX
2017-03-02 8:10 ` Liu, Yong
0 siblings, 1 reply; 4+ messages in thread
From: Xu, HuilongX @ 2017-03-02 7:49 UTC (permalink / raw)
To: Liu, Yong, dts
Hi yong,
Dpdk change merge finish already and not create any tag,
we should merge this patch to dts, because all unit test will can't exec in daily regression.
Thanks a lot
> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, March 02, 2017 3:18 PM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] fix dpdk test app compile issue
>
> Thanks, huilong. If I am right, this patch is for latest dpdk code and not work
> on 17.02.
> Pending merge action after tag for v17.02 created.
>
> On 03/02/2017 03:12 PM, xu,huilong wrote:
> > change list:
> > new dpdk code move code path and make file, default compile will not
> compile app test path.
> > so should compile test app and copy test app to driver compile path.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> > framework/project_dpdk.py | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> > index e2e4b5e..7a4e4f7 100644
> > --- a/framework/project_dpdk.py
> > +++ b/framework/project_dpdk.py
> > @@ -183,6 +183,13 @@ class DPDKdut(Dut):
> >
> > # compile
> > out = self.send_expect("make -j install T=%s %s" % (target,
> > extra_options), "# ", build_time)
> > + #should not check test app compile status, because if test compile fail,
> > + #all unit test can't exec, but others case will exec sucessfull
> > + self.send_expect("make -j -C test/", "# ", build_time)
> > + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-
> pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> > + for app in app_list:
> > + self.send_expect('cp %s ./%s/app' % (app, target), "# ",
> > + 30)
> > +
> >
> > if("Error" in out or "No rule to make" in out):
> > self.logger.error("ERROR - try without '-j'") @@ -191,7
> > +198,6 @@ class DPDKdut(Dut):
> >
> > assert ("Error" not in out), "Compilation error..."
> > assert ("No rule to make" not in out), "No rule to make error..."
> > -
> > def build_install_dpdk_freebsd(self, target, extra_options):
> > """
> > Build DPDK source code on Freebsd with specified target.
> > @@ -206,6 +212,13 @@ class DPDKdut(Dut):
> > out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> > target),
> > "#", 120)
> > + #should not check test app compile status, because if test compile fail,
> > + #all unit test can't exec, but others case will exec sucessfull
> > + self.send_expect("make -j -C test/ CC=gcc48", "# ",
> > + build_time)
> > +
> > + app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-
> pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> > + for app in app_list:
> > + self.send_expect('cp -f %s ./%s/app' % (app, target), "#
> > + ", 30)
> >
> > if("Error" in out or "No rule to make" in out):
> > self.logger.error("ERROR - try without '-j'")
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] fix dpdk test app compile issue
2017-03-02 7:49 ` Xu, HuilongX
@ 2017-03-02 8:10 ` Liu, Yong
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2017-03-02 8:10 UTC (permalink / raw)
To: Xu, HuilongX, dts
Got, applied into master branch and new branch v17.02 for other patches.
On 03/02/2017 03:49 PM, Xu, HuilongX wrote:
> Hi yong,
> Dpdk change merge finish already and not create any tag,
> we should merge this patch to dts, because all unit test will can't exec in daily regression.
> Thanks a lot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-02 8:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 7:12 [dts] [PATCH V1] fix dpdk test app compile issue xu,huilong
2017-03-02 7:18 ` Liu, Yong
2017-03-02 7:49 ` Xu, HuilongX
2017-03-02 8:10 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).