test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V2] fix ring dump case failed
Date: Mon, 06 Mar 2017 09:58:50 +0800	[thread overview]
Message-ID: <58BCC25A.8030803@intel.com> (raw)
In-Reply-To: <1488445860-3000-1-git-send-email-huilongx.xu@intel.com>

Applied with some comments modified. Thanks.

On 03/02/2017 05:11 PM, xu,huilong wrote:
> Testpmd init will create many ring, and last ring name is MP_mbuf_pool_socket_0
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_dump.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
> index a39fcd1..3c508aa 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
>           m = re.compile(r"%s" % match_regex, re.S)
>           result = m.findall(out)
>           
> -
> -        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring name failed")
> +        #Testpmd init will create 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> +        #other ring name about nic bus ID and ring type, so will not check. we only check ring_dump function work ok
> +        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed")
>   
>       def test_mempool_dump(self):
>           """

      reply	other threads:[~2017-03-06  2:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  9:11 xu,huilong
2017-03-06  1:58 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58BCC25A.8030803@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).