test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] fix ring dump case failed
@ 2017-03-02  9:11 xu,huilong
  2017-03-06  1:58 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,huilong @ 2017-03-02  9:11 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

Testpmd init will create many ring, and last ring name is MP_mbuf_pool_socket_0

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_unit_tests_dump.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index a39fcd1..3c508aa 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
         m = re.compile(r"%s" % match_regex, re.S)
         result = m.findall(out)
         
-
-        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring name failed")
+        #Testpmd init will create 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0 
+        #other ring name about nic bus ID and ring type, so will not check. we only check ring_dump function work ok
+        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed")
 
     def test_mempool_dump(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] fix ring dump case failed
  2017-03-02  9:11 [dts] [PATCH V2] fix ring dump case failed xu,huilong
@ 2017-03-06  1:58 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-03-06  1:58 UTC (permalink / raw)
  To: xu,huilong, dts

Applied with some comments modified. Thanks.

On 03/02/2017 05:11 PM, xu,huilong wrote:
> Testpmd init will create many ring, and last ring name is MP_mbuf_pool_socket_0
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_unit_tests_dump.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
> index a39fcd1..3c508aa 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
>           m = re.compile(r"%s" % match_regex, re.S)
>           result = m.findall(out)
>           
> -
> -        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring name failed")
> +        #Testpmd init will create 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> +        #other ring name about nic bus ID and ring type, so will not check. we only check ring_dump function work ok
> +        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed")
>   
>       def test_mempool_dump(self):
>           """

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-06  2:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02  9:11 [dts] [PATCH V2] fix ring dump case failed xu,huilong
2017-03-06  1:58 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).