From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 921A32C35 for ; Mon, 6 Mar 2017 03:06:46 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2017 18:06:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,251,1484035200"; d="scan'208";a="72531126" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga005.fm.intel.com with ESMTP; 05 Mar 2017 18:06:44 -0800 Message-ID: <58BCC25A.8030803@intel.com> Date: Mon, 06 Mar 2017 09:58:50 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,huilong" , dts@dpdk.org References: <1488445860-3000-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1488445860-3000-1-git-send-email-huilongx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V2] fix ring dump case failed X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 02:06:47 -0000 Applied with some comments modified. Thanks. On 03/02/2017 05:11 PM, xu,huilong wrote: > Testpmd init will create many ring, and last ring name is MP_mbuf_pool_socket_0 > > Signed-off-by: xu,huilong > --- > tests/TestSuite_unit_tests_dump.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py > index a39fcd1..3c508aa 100644 > --- a/tests/TestSuite_unit_tests_dump.py > +++ b/tests/TestSuite_unit_tests_dump.py > @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase): > m = re.compile(r"%s" % match_regex, re.S) > result = m.findall(out) > > - > - self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring name failed") > + #Testpmd init will create 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0 > + #other ring name about nic bus ID and ring type, so will not check. we only check ring_dump function work ok > + self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed") > > def test_mempool_dump(self): > """