test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] define build_time in freebsd when compile dpdk
Date: Mon, 06 Mar 2017 16:33:10 +0800	[thread overview]
Message-ID: <58BD1EC6.3010509@intel.com> (raw)
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A4668D5A913@SHSMSX101.ccr.corp.intel.com>

Thanks for clear, applied in.

On 03/06/2017 04:29 PM, Xu, HuilongX wrote:
> Hi yong,
> I use build_time in freebsb compile function in patch "[dts] [PATCH V1] fix dpdk test app compile issue", but I forget  define build_time, only define in linux compile function. So dts will termination
> When run any case on freebsd.
> Thanks a  lot
>> -----Original Message-----
>> From: Liu, Yong
>> Sent: Monday, March 06, 2017 4:25 PM
>> To: Xu, HuilongX; dts@dpdk.org
>> Cc: Xu, HuilongX
>> Subject: RE: [dts] [PATCH V1] define build_time in freebsd when compile
>> dpdk
>>
>> Huilong,
>> Look like build time still remain 120 seconds, what's this patch aim for?
>>
>> Thanks,
>> Marvin
>>
>>> -----Original Message-----
>>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
>>> Sent: Monday, March 06, 2017 10:13 AM
>>> To: dts@dpdk.org
>>> Cc: Xu, HuilongX <huilongx.xu@intel.com>
>>> Subject: [dts] [PATCH V1] define build_time in freebsd when compile
>>> dpdk
>>>
>>> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
>>> ---
>>>   framework/project_dpdk.py | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
>>> index 7a4e4f7..3b91dd6 100644
>>> --- a/framework/project_dpdk.py
>>> +++ b/framework/project_dpdk.py
>>> @@ -207,11 +207,11 @@ class DPDKdut(Dut):
>>>           self.send_expect("rm -rf %s" %
>>> r'./app/test/test_resource_c.res.o' , "#")
>>>           self.send_expect("rm -rf %s" %
>>> r'./app/test/test_resource_tar.res.o' , "#")
>>>           self.send_expect("rm -rf %s" %
>>> r'./app/test/test_pci_sysfs.res.o' , "#")
>>> -
>>> +        build_time = 120
>>>           # compile
>>>           out = self.send_expect("make -j %d install T=%s CC=gcc48" %
>>> (self.number_of_cores,
>>>
>>> target),
>>> -                               "#", 120)
>>> +                               "#", build_time)
>>>           #should not check test app compile status, because if test
>>> compile fail,
>>>           #all unit test can't exec, but others case will exec sucessfull
>>>           self.send_expect("make -j -C test/ CC=gcc48", "# ",
>>> build_time) @@ -224,7 +224,7 @@ class DPDKdut(Dut):
>>>               self.logger.error("ERROR - try without '-j'")
>>>               # if Error try to execute make without -j option
>>>               out = self.send_expect("make install T=%s CC=gcc48" % target,
>>> -                                   "#", 120)
>>> +                                   "#", build_time)
>>>
>>>           assert ("Error" not in out), "Compilation error..."
>>>           assert ("No rule to make" not in out), "No rule to make error..."
>>> --
>>> 1.9.3

      reply	other threads:[~2017-03-06  8:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06  2:13 xu,huilong
2017-03-06  8:24 ` Liu, Yong
2017-03-06  8:29   ` Xu, HuilongX
2017-03-06  8:33     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58BD1EC6.3010509@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).