Re: [dts] [PATCH V1] fix niantic ethtool -i not support issue

["Liu, Yong" <yong.liu@intel.com>]

Huilong,
As I known, kni ixgbe interface should support ethtool driver info dump 
command.
This maybe some kind of issues. Please check again.

Thanks,
Marvin

On 03/07/2017 02:45 PM, xu,huilong wrote:
> The virtual nic by kni on niantic nic, it only support ethool and ethool -k operation.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_kni.py | 23 +++++++++++++----------
>   1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
> index 0825903..0e4211a 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -664,6 +664,19 @@ class TestKni(TestCase):
>                           "ethtool not supported")
>               self.verify("Operation not supported" not in out,
>                           "ethtool not supported")
> +
> +            # Request features status
> +            out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ")
> +            self.verify(("Features for %s" % virtual_interface in out) or
> +                        ("Offload parameters for %s" %
> +                         virtual_interface in out),
> +                        "'ethtool -k' not supported")
> +            self.verify("Operation not supported" not in out,
> +                        "'ethtool -k' not supported")
> +
> +            if self.nic == 'niantic':
> +               # niantic nic only support ethtool and ethtool -k operation
> +                continue
>   
>               # Request driver information
>               out = self.dut.send_expect("ethtool -i %s" % virtual_interface,
> @@ -688,16 +701,6 @@ class TestKni(TestCase):
>                           "'ethtool -S' not supported")
>               self.verify("Operation not supported" not in out,
>                           "ethtool '-S' not supported")
> -
> -            # Request features status
> -            out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ")
> -            self.verify(("Features for %s" % virtual_interface in out) or
> -                        ("Offload parameters for %s" %
> -                         virtual_interface in out),
> -                        "'ethtool -k' not supported")
> -            self.verify("Operation not supported" not in out,
> -                        "'ethtool -k' not supported")
> -
>               # Request ring parameters
>               out = self.dut.send_expect("ethtool -g %s" % virtual_interface,
>                                          "# ")