From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 71F801BBE for ; Wed, 8 Mar 2017 09:14:33 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 00:14:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,262,1486454400"; d="scan'208";a="65382159" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by orsmga004.jf.intel.com with ESMTP; 08 Mar 2017 00:14:31 -0800 Message-ID: <58BFBB83.1070700@intel.com> Date: Wed, 08 Mar 2017 16:06:27 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,huilong" , dts@dpdk.org References: <1488869113-6242-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1488869113-6242-1-git-send-email-huilongx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] fix niantic ethtool -i not support issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 08:14:33 -0000 Huilong, As I known, kni ixgbe interface should support ethtool driver info dump command. This maybe some kind of issues. Please check again. Thanks, Marvin On 03/07/2017 02:45 PM, xu,huilong wrote: > The virtual nic by kni on niantic nic, it only support ethool and ethool -k operation. > > Signed-off-by: xu,huilong > --- > tests/TestSuite_kni.py | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py > index 0825903..0e4211a 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -664,6 +664,19 @@ class TestKni(TestCase): > "ethtool not supported") > self.verify("Operation not supported" not in out, > "ethtool not supported") > + > + # Request features status > + out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ") > + self.verify(("Features for %s" % virtual_interface in out) or > + ("Offload parameters for %s" % > + virtual_interface in out), > + "'ethtool -k' not supported") > + self.verify("Operation not supported" not in out, > + "'ethtool -k' not supported") > + > + if self.nic == 'niantic': > + # niantic nic only support ethtool and ethtool -k operation > + continue > > # Request driver information > out = self.dut.send_expect("ethtool -i %s" % virtual_interface, > @@ -688,16 +701,6 @@ class TestKni(TestCase): > "'ethtool -S' not supported") > self.verify("Operation not supported" not in out, > "ethtool '-S' not supported") > - > - # Request features status > - out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ") > - self.verify(("Features for %s" % virtual_interface in out) or > - ("Offload parameters for %s" % > - virtual_interface in out), > - "'ethtool -k' not supported") > - self.verify("Operation not supported" not in out, > - "'ethtool -k' not supported") > - > # Request ring parameters > out = self.dut.send_expect("ethtool -g %s" % virtual_interface, > "# ")