From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C4CA1F965 for ; Mon, 27 Mar 2017 08:54:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490597680; x=1522133680; h=message-id:date:from:mime-version:to:subject:references: in-reply-to:content-transfer-encoding; bh=3VUZmI05FTI+Hg7CnFdavz8Rz3p/ujw9YtrPqqahZmM=; b=CG+/7lC4kcjCqgeXwbhLk0ex/Y2Hisuu57x2vvVdHkOEWdrMGwjzyZIC 6DLiDs1TAWRxNNCCQZPd8jfqVz7Pmw==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 23:54:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="80925749" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga005.fm.intel.com with ESMTP; 26 Mar 2017 23:54:38 -0700 Message-ID: <58D8B4FF.1070603@intel.com> Date: Mon, 27 Mar 2017 14:45:19 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lijuan Tu , dts@dpdk.org, yulong.pei@intel.com References: <1490583263-111436-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1490583263-111436-1-git-send-email-lijuanx.a.tu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V2 1/2] test_plans/vlan_ethertype_config_test_plan: using outer instead inner to config single vlan tpid X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 06:54:41 -0000 Thanks, applied. On 03/27/2017 10:54 AM, Lijuan Tu wrote: > fix single VLAN tag to be outer VLAN tag > > i40e refer to dpdpk commit: 5b2d37858d32ec6aba78f15dc065f286108d6b4e > ixgbe refer to dpdk commit: 2b84092427b1800cba7d3204b95703b1718fcd28 > > Signed-off-by: Lijuan Tu > --- > test_plans/vlan_ethertype_config_test_plan.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/test_plans/vlan_ethertype_config_test_plan.rst b/test_plans/vlan_ethertype_config_test_plan.rst > index 27dbda7..9d565e7 100644 > --- a/test_plans/vlan_ethertype_config_test_plan.rst > +++ b/test_plans/vlan_ethertype_config_test_plan.rst > @@ -65,7 +65,7 @@ testpmd> start > > 2) change VLAN TPIDs to 0xA100, > > -testpmd> vlan set inner tpid 0xA100 0 > +testpmd> vlan set outer tpid 0xA100 0 > > 3) send a packet with VLAN TPIDs = 0xA100, verify it can be recognized as vlan packet. > > @@ -108,7 +108,7 @@ Verify that the VLAN packet can be received in port ``B`` and TPID is 0x8100 > > 4) Change VLAN TPID to 0xA100 on port ``0`` > > -testpmd> vlan set inner tpid 0xA100 0 > +testpmd> vlan set outer tpid 0xA100 0 > > 5) send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on port ``A``, > Verify that the VLAN packet can be received in port ``B`` and TPID is 0xA100 > @@ -136,7 +136,7 @@ Verify that packet received in port ``B`` without VLAN Tag Identifier > > 3) Change VLAN TPID to 0xA100 on port ``0`` > > -testpmd> vlan set inner tpid 0xA100 0 > +testpmd> vlan set outer tpid 0xA100 0 > > 4) send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on port ``A``, > Verify that packet received in port ``B`` without VLAN Tag Identifier > @@ -169,7 +169,7 @@ Verify that packet received in port ``B`` with VLAN Tag Identifier 16 and TPID i > > 4) Change VLAN TPID to 0xA100 on port ``1`` > > -testpmd> vlan set inner tpid 0xA100 1 > +testpmd> vlan set outer tpid 0xA100 1 > > 5)send 1 packet without VLAN Tag Identifier on port ``A``, > Verify that packet received in port ``B`` with VLAN Tag Identifier 16 and TPID is 0xA100.