test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V3] add --crc-strip param when starting i40evf driver testpmd
Date: Wed, 29 Mar 2017 14:25:08 +0800	[thread overview]
Message-ID: <58DB5344.9020100@intel.com> (raw)
In-Reply-To: <1490769098-113438-1-git-send-email-gangx.xu@intel.com>

Thanks, Gang. Applied.

On 03/29/2017 02:31 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/pmd_output.py | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index 13dcaef..e8e2a2c 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -31,7 +31,7 @@
>   
>   import os
>   import re
> -from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
> +from settings import TIMEOUT, PROTOCOL_PACKET_SIZE, get_nic_driver
>   from utils import create_mask
>   
>   
> @@ -101,6 +101,12 @@ class PmdOutput():
>   
>       def start_testpmd(self, cores, param='', eal_param='', socket=0):
>           # in dpdk2.0 need used --txqflags param to open hardware features
> +        default_param = {'i40evf': ' --crc-strip'}
> +        for (pci_bus, pci_id) in self.dut.pci_devices_info:
> +            driver = get_nic_driver(pci_id)
> +            if default_param.has_key(driver):
> +                if default_param[driver] not in param:
> +                    param += default_param[driver]
>           if "--txqflags" not in param:
>               param += " --txqflags=0"
>   
> @@ -192,6 +198,7 @@ class PmdOutput():
>           Get the allmulticast mode of port.
>           """
>           return self.get_detail_from_port_info("Allmulticast mode: ", "\S+", port_id)
> +
>       def check_tx_bytes(self, tx_bytes, exp_bytes = 0):
>           """
>           fortville nic will send lldp packet when nic setup with testpmd.
> @@ -199,6 +206,7 @@ class PmdOutput():
>           for check tx_bytes count right
>           """
>           return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> +
>       def get_port_vlan_offload(self, port_id):
>           """
>           Function: get the port vlan settting info.

      reply	other threads:[~2017-03-29  6:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29  6:31 xu,gang
2017-03-29  6:25 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58DB5344.9020100@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).