test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V3] add --crc-strip param when starting i40evf driver testpmd
  2017-03-29  6:31 [dts] [PATCH V3] add --crc-strip param when starting i40evf driver testpmd xu,gang
@ 2017-03-29  6:25 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-03-29  6:25 UTC (permalink / raw)
  To: xu,gang, dts

Thanks, Gang. Applied.

On 03/29/2017 02:31 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/pmd_output.py | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index 13dcaef..e8e2a2c 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -31,7 +31,7 @@
>   
>   import os
>   import re
> -from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
> +from settings import TIMEOUT, PROTOCOL_PACKET_SIZE, get_nic_driver
>   from utils import create_mask
>   
>   
> @@ -101,6 +101,12 @@ class PmdOutput():
>   
>       def start_testpmd(self, cores, param='', eal_param='', socket=0):
>           # in dpdk2.0 need used --txqflags param to open hardware features
> +        default_param = {'i40evf': ' --crc-strip'}
> +        for (pci_bus, pci_id) in self.dut.pci_devices_info:
> +            driver = get_nic_driver(pci_id)
> +            if default_param.has_key(driver):
> +                if default_param[driver] not in param:
> +                    param += default_param[driver]
>           if "--txqflags" not in param:
>               param += " --txqflags=0"
>   
> @@ -192,6 +198,7 @@ class PmdOutput():
>           Get the allmulticast mode of port.
>           """
>           return self.get_detail_from_port_info("Allmulticast mode: ", "\S+", port_id)
> +
>       def check_tx_bytes(self, tx_bytes, exp_bytes = 0):
>           """
>           fortville nic will send lldp packet when nic setup with testpmd.
> @@ -199,6 +206,7 @@ class PmdOutput():
>           for check tx_bytes count right
>           """
>           return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> +
>       def get_port_vlan_offload(self, port_id):
>           """
>           Function: get the port vlan settting info.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V3] add --crc-strip param when starting i40evf driver testpmd
@ 2017-03-29  6:31 xu,gang
  2017-03-29  6:25 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2017-03-29  6:31 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 framework/pmd_output.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 13dcaef..e8e2a2c 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -31,7 +31,7 @@
 
 import os
 import re
-from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
+from settings import TIMEOUT, PROTOCOL_PACKET_SIZE, get_nic_driver
 from utils import create_mask
 
 
@@ -101,6 +101,12 @@ class PmdOutput():
 
     def start_testpmd(self, cores, param='', eal_param='', socket=0):
         # in dpdk2.0 need used --txqflags param to open hardware features
+        default_param = {'i40evf': ' --crc-strip'}
+        for (pci_bus, pci_id) in self.dut.pci_devices_info:
+            driver = get_nic_driver(pci_id)
+            if default_param.has_key(driver):
+                if default_param[driver] not in param:
+                    param += default_param[driver]
         if "--txqflags" not in param:
             param += " --txqflags=0"
 
@@ -192,6 +198,7 @@ class PmdOutput():
         Get the allmulticast mode of port.
         """
         return self.get_detail_from_port_info("Allmulticast mode: ", "\S+", port_id)
+
     def check_tx_bytes(self, tx_bytes, exp_bytes = 0):
         """
         fortville nic will send lldp packet when nic setup with testpmd.
@@ -199,6 +206,7 @@ class PmdOutput():
         for check tx_bytes count right
         """
         return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
+
     def get_port_vlan_offload(self, port_id):
         """
         Function: get the port vlan settting info.
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-29  6:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29  6:31 [dts] [PATCH V3] add --crc-strip param when starting i40evf driver testpmd xu,gang
2017-03-29  6:25 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).