From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 9E9472C55
 for <dts@dpdk.org>; Wed, 29 Mar 2017 08:34:38 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga104.jf.intel.com with ESMTP; 28 Mar 2017 23:34:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="66310551"
Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116])
 ([10.239.128.116])
 by orsmga002.jf.intel.com with ESMTP; 28 Mar 2017 23:34:36 -0700
Message-ID: <58DB5344.9020100@intel.com>
Date: Wed, 29 Mar 2017 14:25:08 +0800
From: "Liu, Yong" <yong.liu@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
References: <1490769098-113438-1-git-send-email-gangx.xu@intel.com>
In-Reply-To: <1490769098-113438-1-git-send-email-gangx.xu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dts] [PATCH V3] add --crc-strip param when starting i40evf
 driver testpmd
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2017 06:34:39 -0000

Thanks, Gang. Applied.

On 03/29/2017 02:31 PM, xu,gang wrote:
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/pmd_output.py | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index 13dcaef..e8e2a2c 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -31,7 +31,7 @@
>   
>   import os
>   import re
> -from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
> +from settings import TIMEOUT, PROTOCOL_PACKET_SIZE, get_nic_driver
>   from utils import create_mask
>   
>   
> @@ -101,6 +101,12 @@ class PmdOutput():
>   
>       def start_testpmd(self, cores, param='', eal_param='', socket=0):
>           # in dpdk2.0 need used --txqflags param to open hardware features
> +        default_param = {'i40evf': ' --crc-strip'}
> +        for (pci_bus, pci_id) in self.dut.pci_devices_info:
> +            driver = get_nic_driver(pci_id)
> +            if default_param.has_key(driver):
> +                if default_param[driver] not in param:
> +                    param += default_param[driver]
>           if "--txqflags" not in param:
>               param += " --txqflags=0"
>   
> @@ -192,6 +198,7 @@ class PmdOutput():
>           Get the allmulticast mode of port.
>           """
>           return self.get_detail_from_port_info("Allmulticast mode: ", "\S+", port_id)
> +
>       def check_tx_bytes(self, tx_bytes, exp_bytes = 0):
>           """
>           fortville nic will send lldp packet when nic setup with testpmd.
> @@ -199,6 +206,7 @@ class PmdOutput():
>           for check tx_bytes count right
>           """
>           return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> +
>       def get_port_vlan_offload(self, port_id):
>           """
>           Function: get the port vlan settting info.