From: "Liu, Yong" <yong.liu@intel.com>
To: Lijuan Tu <lijuanx.a.tu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] nics/net_device: fix removeobj bug.
Date: Wed, 29 Mar 2017 14:47:29 +0800 [thread overview]
Message-ID: <58DB5881.3060804@intel.com> (raw)
In-Reply-To: <1490666124-112244-1-git-send-email-lijuanx.a.tu@intel.com>
Thanks, Lijuan. Applied.
On 03/28/2017 09:55 AM, Lijuan Tu wrote:
> Remove all the match network device object, not only the first one.
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
> nics/net_device.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nics/net_device.py b/nics/net_device.py
> index ba3d9c2..0af4ad5 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -885,7 +885,7 @@ def remove_from_list(host):
> Remove network device object from global structure
> Parameter will by host ip
> """
> - for nic in NICS_LIST:
> + for nic in NICS_LIST[:]:
> if host == nic['host']:
> NICS_LIST.remove(nic)
>
prev parent reply other threads:[~2017-03-29 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 1:55 Lijuan Tu
2017-03-29 6:47 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DB5881.3060804@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=lijuanx.a.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).