From: "Liu, Yong" <yong.liu@intel.com>
To: Xueqin Lin <xueqin.lin@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] add vlan filter script to VF daemon suite
Date: Thu, 20 Apr 2017 14:49:14 +0800 [thread overview]
Message-ID: <58F859EA.6010905@intel.com> (raw)
In-Reply-To: <1491869396-6935-1-git-send-email-xueqin.lin@intel.com>
Xueqin,
One question about the way calculate wrong vlan id. Why it is generated
by correct vlan plus 2 and then mod 4095?
I think ( vlan + 1 ) % 4096 will be more suitable.
Thanks,
Marvin
On 04/11/2017 08:09 AM, Xueqin Lin wrote:
> + for rx_vlan in rx_vlans:
> + self.dut_testpmd.execute_cmd('rx_vlan add %s port 0 vf 1'% rx_vlan)
> + time.sleep(1)
> + out = self.send_and_pmdout(wrong_mac, rx_vlan)
> + self.verify("dst=%s" % wrong_mac in out,
> + "Failed to enable vlan filter!!!")
> + self.verify("VLAN tci=%s" % hex(rx_vlan) in out,
> + "Failed to receive packet with vlan id!!!")
> +
> + wrong_rx_vlan = (rx_vlan + 2) % 4095
next prev parent reply other threads:[~2017-04-20 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 0:09 Xueqin Lin
2017-04-20 6:49 ` Liu, Yong [this message]
2017-04-20 9:14 ` Lin, Xueqin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58F859EA.6010905@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).