test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Xueqin Lin <xueqin.lin@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk.
Date: Thu, 27 Apr 2017 13:05:36 +0800	[thread overview]
Message-ID: <59017C20.4020704@intel.com> (raw)
In-Reply-To: <1492738052-9493-1-git-send-email-xueqin.lin@intel.com>

Xueqin, please add signed-off tag and some information like below in 
comment log.

i40e VF HW crc-strip default enabled after commit 60da774e.

On 04/21/2017 09:27 AM, Xueqin Lin wrote:
> ---
>   framework/pmd_output.py | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index f52332b..ca361a7 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -101,12 +101,6 @@ class PmdOutput():
>   
>       def start_testpmd(self, cores, param='', eal_param='', socket=0):
>           # in dpdk2.0 need used --txqflags param to open hardware features
> -        default_param = {'i40evf': ' --crc-strip'}
> -        for (pci_bus, pci_id) in self.dut.pci_devices_info:
> -            driver = get_nic_driver(pci_id)
> -            if default_param.has_key(driver):
> -                if default_param[driver] not in param:
> -                    param += default_param[driver]
>           if "--txqflags" not in param:
>               param += " --txqflags=0"
>   

      reply	other threads:[~2017-04-27  5:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21  1:27 Xueqin Lin
2017-04-27  5:05 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59017C20.4020704@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).