* [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk.
@ 2017-04-21 1:27 Xueqin Lin
2017-04-27 5:05 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Xueqin Lin @ 2017-04-21 1:27 UTC (permalink / raw)
To: dts; +Cc: Xueqin Lin
---
framework/pmd_output.py | 6 ------
1 file changed, 6 deletions(-)
diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index f52332b..ca361a7 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -101,12 +101,6 @@ class PmdOutput():
def start_testpmd(self, cores, param='', eal_param='', socket=0):
# in dpdk2.0 need used --txqflags param to open hardware features
- default_param = {'i40evf': ' --crc-strip'}
- for (pci_bus, pci_id) in self.dut.pci_devices_info:
- driver = get_nic_driver(pci_id)
- if default_param.has_key(driver):
- if default_param[driver] not in param:
- param += default_param[driver]
if "--txqflags" not in param:
param += " --txqflags=0"
--
2.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk.
2017-04-21 1:27 [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk Xueqin Lin
@ 2017-04-27 5:05 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-04-27 5:05 UTC (permalink / raw)
To: Xueqin Lin, dts
Xueqin, please add signed-off tag and some information like below in
comment log.
i40e VF HW crc-strip default enabled after commit 60da774e.
On 04/21/2017 09:27 AM, Xueqin Lin wrote:
> ---
> framework/pmd_output.py | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index f52332b..ca361a7 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -101,12 +101,6 @@ class PmdOutput():
>
> def start_testpmd(self, cores, param='', eal_param='', socket=0):
> # in dpdk2.0 need used --txqflags param to open hardware features
> - default_param = {'i40evf': ' --crc-strip'}
> - for (pci_bus, pci_id) in self.dut.pci_devices_info:
> - driver = get_nic_driver(pci_id)
> - if default_param.has_key(driver):
> - if default_param[driver] not in param:
> - param += default_param[driver]
> if "--txqflags" not in param:
> param += " --txqflags=0"
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-27 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-21 1:27 [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk Xueqin Lin
2017-04-27 5:05 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).