From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C0469559C for ; Thu, 27 Apr 2017 07:17:02 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2017 22:17:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="94702809" Received: from stv-crb-56.sh.intel.com (HELO [10.239.128.116]) ([10.239.128.116]) by fmsmga006.fm.intel.com with ESMTP; 26 Apr 2017 22:17:00 -0700 Message-ID: <59017C20.4020704@intel.com> Date: Thu, 27 Apr 2017 13:05:36 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Xueqin Lin , dts@dpdk.org References: <1492738052-9493-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1492738052-9493-1-git-send-email-xueqin.lin@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH] Remove crc-strip parameter due to adding defaultly in dpdk. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 05:17:03 -0000 Xueqin, please add signed-off tag and some information like below in comment log. i40e VF HW crc-strip default enabled after commit 60da774e. On 04/21/2017 09:27 AM, Xueqin Lin wrote: > --- > framework/pmd_output.py | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/framework/pmd_output.py b/framework/pmd_output.py > index f52332b..ca361a7 100644 > --- a/framework/pmd_output.py > +++ b/framework/pmd_output.py > @@ -101,12 +101,6 @@ class PmdOutput(): > > def start_testpmd(self, cores, param='', eal_param='', socket=0): > # in dpdk2.0 need used --txqflags param to open hardware features > - default_param = {'i40evf': ' --crc-strip'} > - for (pci_bus, pci_id) in self.dut.pci_devices_info: > - driver = get_nic_driver(pci_id) > - if default_param.has_key(driver): > - if default_param[driver] not in param: > - param += default_param[driver] > if "--txqflags" not in param: > param += " --txqflags=0" >