From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V2] fix user space ethtool failed case
Date: Fri, 12 May 2017 17:07:15 +0800 [thread overview]
Message-ID: <59157B43.50101@intel.com> (raw)
In-Reply-To: <1494575072-44798-7-git-send-email-huilongx.xu@intel.com>
Huilong, some comments below.
On 05/12/2017 03:44 PM, xu,huilong wrote:
> 1. update user space ethtool compile error, becauese the example path update in dpdk already
> 2. kernel space ethtool dump nic eeprom file size differnet dpdk user space ethtool, so should
> cat out dpdk ethtool dump nic eeprom file and the file size same with kernel ethtool. then use
> file md5 check the file is same
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> tests/TestSuite_userspace_ethtool.py | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
> index 937a9e5..36ff104 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -61,7 +61,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
> self.verify("Error" not in out, "compilation error 1")
> self.verify("No such file" not in out, "compilation error 2")
>
> - path = "./examples/ethtool/ethtool-app/ethtool-app/%s/ethtool" % self.target
> + path = "./examples/ethtool/ethtool-app/%s/ethtool" % self.target
> self.cmd = "%s -c f -n %d" % (path, self.dut.get_memory_channels())
>
> # pause frame basic configuration
> @@ -370,7 +370,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
> self.dut.send_expect("ethtool --eeprom-dump %s raw on > %s" % (intf, ethtool_eeprom), "# ")
> # wait for file ready
> time.sleep(2)
> - portinfo['ethtool_eeprom'] = ethtool_eeprom
> + dpdk_eeprom_size = int(self.dut.send_expect('ls -all %s' % portinfo['eeprom_file'], '# ').split(' ')[4].strip())
There's one simple command "stat -c \%s file" to strip file size.
> + self.dut.send_expect('dd if=%s of=%s bs=%d count=1' % (ethtool_eeprom, "ethtool_eeprom_%d_cat.bin" % index, dpdk_eeprom_size), "#")
> + portinfo['ethtool_eeprom'] = "ethtool_eeprom_%d_cat.bin" % index
> # bind to original driver
> portinfo['net_dev'].bind_driver(portinfo['ori_driver'])
>
> @@ -499,8 +501,10 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
> for index in range(len(self.ports)):
> port = self.ports[index]
> ori_rx_pkts, _ = self.strip_portstats(index)
> + time.sleep(10)
> # stop port
> self.dut.send_expect("stop %d" % index, "EthApp>")
> + time.sleep(10)
Sleep 20 seconds seem too long, please explain why need this.
> # check packet not forwarded when port is stop
> pkt = Packet()
> tester_port = self.tester.get_local_port(port)
next prev parent reply other threads:[~2017-05-12 9:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 7:44 [dts] [PATCH V2] add filter lldp in sniff model xu,huilong
2017-05-12 7:44 ` [dts] [PATCH V2] add fortville 25G NIC for this case xu,huilong
2017-05-12 8:47 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 1/2] add link bonding rss dynamic config test plane xu,huilong
2017-05-15 2:30 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH] fix check packet failure by lldp have different packet size xu,huilong
2017-05-15 2:54 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] fix test app compile error xu,huilong
2017-05-12 8:57 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] fix timeout when setup dpdk app xu,huilong
2017-05-12 9:01 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] fix user space ethtool failed case xu,huilong
2017-05-12 9:07 ` Liu, Yong [this message]
2017-05-15 1:27 ` Xu, HuilongX
2017-05-12 7:44 ` [dts] [PATCH] remove --crc-strip parameter in testpmd xu,huilong
2017-05-12 9:10 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 1/2] update fdir test case xu,huilong
2017-05-15 2:19 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] update testpmd path in dpdk xu,huilong
2017-05-12 9:12 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 2/2] add link bond slave dynamic config test case xu,huilong
2017-05-12 8:53 ` Liu, Yong
2017-05-15 1:08 ` Xu, HuilongX
2017-05-12 7:44 ` [dts] [PATCH 2/2] update fdir test plane xu,huilong
2017-05-15 2:16 ` Liu, Yong
2017-05-12 8:45 ` [dts] [PATCH V2] add filter lldp in sniff model Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59157B43.50101@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=huilongx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).