From: "Liu, Yong" <yong.liu@intel.com>
To: Peng Yuan <yuan.peng@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH v2] tests: fix the bug of verifyResult_symmetric of pmdrss_hash
Date: Mon, 15 May 2017 09:01:45 +0800 [thread overview]
Message-ID: <5918FDF9.4040700@intel.com> (raw)
In-Reply-To: <1493832439-182586-1-git-send-email-yuan.peng@intel.com>
Yuan, please add some descriptions for your changes in the commit log.
On 05/04/2017 01:27 AM, Peng Yuan wrote:
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>
>
> diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
> index 78ae34d..612042d 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -374,9 +374,49 @@ class TestPmdrssHash(TestCase):
> reta_line[name.strip()] = value.strip()
> reta_lines.append(reta_line)
>
> - self.verifyResult_symmetric()
> + def verifyResult_simple_symmetric(self):
> + """
> + Verify whether or not the result passes.
> + """
> +
> + global reta_lines
> + global reta_num
> + result = []
> + self.result_table_create(
> + ['packet index', 'RSS hash', 'hash index', 'queue id', 'actual queue id', 'pass '])
> +
> + i = 0
> + for tmp_reta_line in reta_lines:
> + status = "true"
> + # compute the hash result of five tuple into the 7 LSBs value.
> + hash_index = int(tmp_reta_line["RSS hash"], 16) % reta_num
> +
> + if(i % 2 == 1):
> + if(pre_RSS_hash == tmp_reta_line["RSS hash"]):
> + if(int(tmp_reta_line["RSS hash"], 16) > int("ffff", 16)):
> + status = "true"
> + result.insert((i - 1) / 2, 0)
> + elif(reta_entries[hash_index] == int(tmp_reta_line["queue"])):
> + status = "true"
> + result.insert((i - 1) / 2, 0)
> + else:
> + status = "fail"
> + result.insert((i - 1) / 2, 0)
> + else:
> + status = "fail"
> + result.insert((i - 1) / 2, 1)
> + pre_RSS_hash = tmp_reta_line["RSS hash"]
>
> - def verifyResult_symmetric(self):
> + self.result_table_add(
> + [i, tmp_reta_line["RSS hash"], hash_index, reta_entries[hash_index], tmp_reta_line["queue"], status])
> + i = i + 1
> +
> + self.result_table_print()
> + reta_lines = []
> + self.verify(
> + sum(result) == 0, "the symmetric RSS hash function failed!")
> +
> + def verifyResult_toeplitz_symmetric(self):
> """
> Verify whether or not the result passes.
> """
> @@ -395,8 +435,12 @@ class TestPmdrssHash(TestCase):
>
> if(i % 2 == 1):
> if(pre_RSS_hash == tmp_reta_line["RSS hash"]):
> - status = "true"
> - result.insert((i - 1) / 2, 0)
> + if(reta_entries[hash_index] == int(tmp_reta_line["queue"])):
> + status = "true"
> + result.insert((i - 1) / 2, 0)
> + else:
> + status = "fail"
> + result.insert((i - 1) / 2, 0)
> else:
> status = "fail"
> result.insert((i - 1) / 2, 1)
> @@ -539,6 +583,8 @@ class TestPmdrssHash(TestCase):
>
> self.send_packet_symmetric(itf, iptype)
>
> + self.verifyResult_toeplitz_symmetric()
> +
> self.dut.send_expect("quit", "# ", 30)
>
> def test_simple(self):
> @@ -649,6 +695,8 @@ class TestPmdrssHash(TestCase):
>
> self.send_packet_symmetric(itf, iptype)
>
> + self.verifyResult_simple_symmetric()
> +
> self.dut.send_expect("quit", "# ", 30)
>
> def tear_down(self):
prev parent reply other threads:[~2017-05-15 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 17:27 Peng Yuan
2017-05-15 1:01 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5918FDF9.4040700@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).