From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH] fix check packet failure by lldp have different packet size
Date: Mon, 15 May 2017 10:54:23 +0800 [thread overview]
Message-ID: <5919185F.1010102@intel.com> (raw)
In-Reply-To: <1494575072-44798-4-git-send-email-huilongx.xu@intel.com>
Huilong, some comments below.
On 05/12/2017 03:44 PM, xu,huilong wrote:
> fortville will send different size lldp packet, so should update chcek function.
> now we know lldp size is 110 or 100 in dpdk17.05 by debug.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> framework/pmd_output.py | 5 ++++-
> framework/settings.py | 2 +-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index ca361a7..8fdf4c9 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -203,8 +203,11 @@ class PmdOutput():
> so should used (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> for check tx_bytes count right
> """
> - return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> + flage = 1
> + for size in PROTOCOL_PACKET_SIZE['lldp']:
> + flage = flage and (tx_bytes - exp_bytes) % size
>
Not sure the meaning of flage, please change it to more meaningful name
like error_flag.
> + return not flage
> def get_port_vlan_offload(self, port_id):
> """
> Function: get the port vlan settting info.
> diff --git a/framework/settings.py b/framework/settings.py
> index 342314d..3839859 100644
> --- a/framework/settings.py
> +++ b/framework/settings.py
> @@ -173,7 +173,7 @@ HEADER_SIZE = {
> dpdk send protocol packet size.
> """
> PROTOCOL_PACKET_SIZE = {
> - 'lldp': 110,
> + 'lldp': [110,100],
Add space between two numbers.
> }
>
> """
next prev parent reply other threads:[~2017-05-15 3:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 7:44 [dts] [PATCH V2] add filter lldp in sniff model xu,huilong
2017-05-12 7:44 ` [dts] [PATCH V2] add fortville 25G NIC for this case xu,huilong
2017-05-12 8:47 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 1/2] add link bonding rss dynamic config test plane xu,huilong
2017-05-15 2:30 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH] fix check packet failure by lldp have different packet size xu,huilong
2017-05-15 2:54 ` Liu, Yong [this message]
2017-05-12 7:44 ` [dts] [PATCH V2] fix test app compile error xu,huilong
2017-05-12 8:57 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] fix timeout when setup dpdk app xu,huilong
2017-05-12 9:01 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] fix user space ethtool failed case xu,huilong
2017-05-12 9:07 ` Liu, Yong
2017-05-15 1:27 ` Xu, HuilongX
2017-05-12 7:44 ` [dts] [PATCH] remove --crc-strip parameter in testpmd xu,huilong
2017-05-12 9:10 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 1/2] update fdir test case xu,huilong
2017-05-15 2:19 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH V2] update testpmd path in dpdk xu,huilong
2017-05-12 9:12 ` Liu, Yong
2017-05-12 7:44 ` [dts] [PATCH 2/2] add link bond slave dynamic config test case xu,huilong
2017-05-12 8:53 ` Liu, Yong
2017-05-15 1:08 ` Xu, HuilongX
2017-05-12 7:44 ` [dts] [PATCH 2/2] update fdir test plane xu,huilong
2017-05-15 2:16 ` Liu, Yong
2017-05-12 8:45 ` [dts] [PATCH V2] add filter lldp in sniff model Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5919185F.1010102@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=huilongx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).