From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V3] fix check packet failure by lldp have different packet size
Date: Mon, 15 May 2017 13:09:44 +0800 [thread overview]
Message-ID: <59193818.9090600@intel.com> (raw)
In-Reply-To: <1494821638-48469-1-git-send-email-huilongx.xu@intel.com>
Huilong, please make sure code align to pep8.
On 05/15/2017 12:13 PM, xu,huilong wrote:
> fortville will send different size lldp packet, so should update chcek function.
> now we know lldp size is 110 or 100 in dpdk17.05 by debug.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> framework/pmd_output.py | 6 +++++-
> framework/settings.py | 2 +-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index ca361a7..4667e77 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -203,8 +203,12 @@ class PmdOutput():
> so should used (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> for check tx_bytes count right
> """
> - return not (tx_bytes - exp_bytes) % PROTOCOL_PACKET_SIZE['lldp']
> + # error_flage is true means tx_bytes different with expect bytes
> + error_flage = 1
> + for size in PROTOCOL_PACKET_SIZE['lldp']:
> + error_flage = error_flage and (tx_bytes - exp_bytes) % size
>
> + return not error_flage
Please add space line between functions.
> def get_port_vlan_offload(self, port_id):
> """
> Function: get the port vlan settting info.
> diff --git a/framework/settings.py b/framework/settings.py
> index 342314d..3839859 100644
> --- a/framework/settings.py
> +++ b/framework/settings.py
> @@ -173,7 +173,7 @@ HEADER_SIZE = {
> dpdk send protocol packet size.
> """
> PROTOCOL_PACKET_SIZE = {
> - 'lldp': 110,
> + 'lldp': [110,100],
Please add space between two numbers.
> }
>
> """
prev parent reply other threads:[~2017-05-15 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 4:13 xu,huilong
2017-05-15 5:09 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59193818.9090600@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=huilongx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).