* [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used
@ 2017-07-05 8:24 Herbert Guan
2017-07-05 9:02 ` Jianbo Liu
2017-07-06 13:28 ` Liu, Yong
0 siblings, 2 replies; 3+ messages in thread
From: Herbert Guan @ 2017-07-05 8:24 UTC (permalink / raw)
To: dts; +Cc: Herbert Guan
It's necessary to allow user selecting the nic and target options after reading out the default execution templates.
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
tools/setup.py | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tools/setup.py b/tools/setup.py
index 090dda9..cc51ec5 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -259,23 +259,23 @@ def config_execution():
opt = Option(**suites_option)
suites = opt.parse_input()
- nics = ['cfg']
- nics += NICS.keys()
- nic_option = {'prompt': 'Choose one of nics',
- 'type': 'choice',
- 'help': 'Choose one of dpdk support NIC',
- 'options': nics,
- 'default': '0'}
- opt = Option(**nic_option)
- nic_type = opt.parse_input()
-
- target_option = {'prompt': 'Choose target for execution',
- 'type': 'choice',
- 'help': 'Choose one of dpdk targets',
- 'options': targets,
- 'default': '0'}
- opt = Option(**target_option)
- target = opt.parse_input()
+ nics = ['cfg']
+ nics += NICS.keys()
+ nic_option = {'prompt': 'Choose one of nics',
+ 'type': 'choice',
+ 'help': 'Choose one of dpdk support NIC',
+ 'options': nics,
+ 'default': '0'}
+ opt = Option(**nic_option)
+ nic_type = opt.parse_input()
+
+ target_option = {'prompt': 'Choose target for execution',
+ 'type': 'choice',
+ 'help': 'Choose one of dpdk targets',
+ 'options': targets,
+ 'default': '0'}
+ opt = Option(**target_option)
+ target = opt.parse_input()
driver_option = {'prompt': 'Choose one of them',
'type': 'choice',
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used
2017-07-05 8:24 [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used Herbert Guan
@ 2017-07-05 9:02 ` Jianbo Liu
2017-07-06 13:28 ` Liu, Yong
1 sibling, 0 replies; 3+ messages in thread
From: Jianbo Liu @ 2017-07-05 9:02 UTC (permalink / raw)
To: Herbert Guan; +Cc: dts
On 5 July 2017 at 16:24, Herbert Guan <herbert.guan@arm.com> wrote:
> It's necessary to allow user selecting the nic and target options after reading out the default execution templates.
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
> tools/setup.py | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/tools/setup.py b/tools/setup.py
> index 090dda9..cc51ec5 100755
> --- a/tools/setup.py
> +++ b/tools/setup.py
> @@ -259,23 +259,23 @@ def config_execution():
> opt = Option(**suites_option)
> suites = opt.parse_input()
>
> - nics = ['cfg']
> - nics += NICS.keys()
> - nic_option = {'prompt': 'Choose one of nics',
> - 'type': 'choice',
> - 'help': 'Choose one of dpdk support NIC',
> - 'options': nics,
> - 'default': '0'}
> - opt = Option(**nic_option)
> - nic_type = opt.parse_input()
> -
> - target_option = {'prompt': 'Choose target for execution',
> - 'type': 'choice',
> - 'help': 'Choose one of dpdk targets',
> - 'options': targets,
> - 'default': '0'}
> - opt = Option(**target_option)
> - target = opt.parse_input()
> + nics = ['cfg']
> + nics += NICS.keys()
> + nic_option = {'prompt': 'Choose one of nics',
> + 'type': 'choice',
> + 'help': 'Choose one of dpdk support NIC',
> + 'options': nics,
> + 'default': '0'}
> + opt = Option(**nic_option)
> + nic_type = opt.parse_input()
> +
> + target_option = {'prompt': 'Choose target for execution',
> + 'type': 'choice',
> + 'help': 'Choose one of dpdk targets',
> + 'options': targets,
> + 'default': '0'}
> + opt = Option(**target_option)
> + target = opt.parse_input()
>
> driver_option = {'prompt': 'Choose one of them',
> 'type': 'choice',
> --
> 1.8.3.1
>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used
2017-07-05 8:24 [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used Herbert Guan
2017-07-05 9:02 ` Jianbo Liu
@ 2017-07-06 13:28 ` Liu, Yong
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2017-07-06 13:28 UTC (permalink / raw)
To: Herbert Guan, dts
Thanks, applied.
On 07/05/2017 04:24 PM, Herbert Guan wrote:
> It's necessary to allow user selecting the nic and target options after reading out the default execution templates.
> Signed-off-by: Herbert Guan<herbert.guan@arm.com>
> ---
> tools/setup.py | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-06 4:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 8:24 [dts] [PATCH] Allow to select nic and target options if default execution templates are to be used Herbert Guan
2017-07-05 9:02 ` Jianbo Liu
2017-07-06 13:28 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).