* [dts] [PATCH] tests/short_live: fix issues in wating for link status up
@ 2017-08-07 9:57 Herbert Guan
2017-08-09 18:00 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Guan @ 2017-08-07 9:57 UTC (permalink / raw)
To: dts; +Cc: Herbert Guan
fixes: 78212a000d ("tests/short_live: fixes the result parsing issue")
For fiber links, no "LSC event" is expected. So "testpmd>" is the
correct string to check.
Change to use sleep(5) for non-fiber links to wait for the links up.
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
tests/TestSuite_short_live.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 61e99c8..d153975 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -125,7 +125,8 @@ class TestShortLiveApp(TestCase):
Basic rx/tx forwarding test
"""
#dpdk start
- self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --portmask=0x3" % self.target, "LSC event", 120)
+ self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --portmask=0x3" % self.target, "testpmd>", 120)
+ time.sleep(5)
self.dut.send_expect("set fwd mac", "testpmd>")
self.dut.send_expect("set promisc all off", "testpmd>")
self.dut.send_expect("start", "testpmd>")
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] tests/short_live: fix issues in wating for link status up
2017-08-07 9:57 [dts] [PATCH] tests/short_live: fix issues in wating for link status up Herbert Guan
@ 2017-08-09 18:00 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-08-09 18:00 UTC (permalink / raw)
To: Herbert Guan, dts
Thanks Herbert. Applied. By now waiting few seconds for link stability
is the most appropriate way for different kinds of NICs.
On 08/07/2017 05:57 PM, Herbert Guan wrote:
> fixes: 78212a000d ("tests/short_live: fixes the result parsing issue")
> For fiber links, no "LSC event" is expected. So "testpmd>" is the
> correct string to check.
> Change to use sleep(5) for non-fiber links to wait for the links up.
>
> Signed-off-by: Herbert Guan<herbert.guan@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-09 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-07 9:57 [dts] [PATCH] tests/short_live: fix issues in wating for link status up Herbert Guan
2017-08-09 18:00 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).